chrome/browser/ui/views/tabs/tab_strip.cc - Issue 2947593005: Use ContainsValue() instead of std::find() in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 2947593005: Use ContainsValue() instead of std::find() in chrome/browser/ui/ (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc

index fcac86589af36bc0882147297b6199add7b2df22..44ec82e763b4d74bec43bb08ed743ba4efde9f21 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/tab_strip.cc

@@ -1180,7 +1180,7 @@ void TabStrip::MaybeStartDrag(

}

DCHECK(!tabs.empty());

- DCHECK(std::find(tabs.begin(), tabs.end(), tab) != tabs.end());

+ DCHECK(base::ContainsValue(tabs, tab));

ui::ListSelectionModel selection_model;

if (!original_selection.IsSelected(model_index))

selection_model.Copy(original_selection);