Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 294753003: Fix clang -Wwritable-strings warnings in the Windows sandbox (Closed)

Created:
6 years, 7 months ago by Reid Kleckner
Modified:
6 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Fix clang -Wwritable-strings warnings in the Windows sandbox R=cpu@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M sandbox/win/src/job.h View 1 chunk +3 lines, -1 line 0 comments Download
M sandbox/win/src/job.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/named_pipe_policy_test.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M sandbox/win/src/policy_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/policy_low_level_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Reid Kleckner
6 years, 7 months ago (2014-05-19 22:24:26 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 7 months ago (2014-05-20 00:38:06 UTC) #2
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 7 months ago (2014-05-20 00:38:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/294753003/1
6 years, 7 months ago (2014-05-20 00:39:15 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:32:54 UTC) #5
Message was sent while issue was closed.
Change committed as 271591

Powered by Google App Engine
This is Rietveld 408576698