Issue 2947443002: Using identical(xxx, typeProvider.yyy) is not compatible with Analysis Driver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2947443002: Using identical(xxx, typeProvider.yyy) is not compatible with Analysis Driver. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Using identical(xxx, typeProvider.yyy) is not compatible with Analysis Driver. This fixes 8 out of 22 failing tests for DDC using Analysis Driver. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bf5ea8f5931bb5761621bd5f8ca97754ab63dc78

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/dart/constant/evaluation.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as bf5ea8f5931bb5761621bd5f8ca97754ab63dc78 (presubmit successful).

3 years, 6 months ago (2017-06-16 20:38:39 UTC) #4

Brian Wilkerson

3 years, 6 months ago (2017-06-17 16:04:10 UTC) #5

Message was sent while issue was closed.

lgtm. Are there other uses of identical that we should similarly replace?