chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 2947413002: Restrict CM API interface request and message dispatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2947413002: Restrict CM API interface request and message dispatch. (Closed)

Patch Set: Addressed comments, and used an associated interface. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/password_manager/credential_manager_browsertest.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index 0c5d528993f19bdcf6b1afd44e748c47b28e296b..dff90f3c72b643d6bb33c2ffba4468693011a0a0 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -577,7 +577,7 @@ TEST_F(ChromePasswordManagerClientTest, BindCredentialManager_MissingInstance) {

// This call should not crash.

ChromePasswordManagerClient::BindCredentialManager(

service_manager::BindSourceInfo(),

- password_manager::mojom::CredentialManagerRequest(),

+ password_manager::mojom::CredentialManagerAssociatedRequest(),

web_contents->GetMainFrame());

}