Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.h

Issue 2947413002: Restrict CM API interface request and message dispatch. (Closed)
Patch Set: Address nit from clamy@. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/credential_manager_impl.h
diff --git a/components/password_manager/content/browser/credential_manager_impl.h b/components/password_manager/content/browser/credential_manager_impl.h
index 6db0b992f106151e058e8106c7c3c1cd073f78a0..4e6369dfe306d7f1b643316722b0d819e3c0c39f 100644
--- a/components/password_manager/content/browser/credential_manager_impl.h
+++ b/components/password_manager/content/browser/credential_manager_impl.h
@@ -18,7 +18,7 @@
#include "components/password_manager/core/common/credential_manager_types.h"
#include "components/prefs/pref_member.h"
#include "content/public/browser/web_contents_observer.h"
-#include "mojo/public/cpp/bindings/binding_set.h"
+#include "mojo/public/cpp/bindings/associated_binding.h"
class GURL;
@@ -48,7 +48,9 @@ class CredentialManagerImpl
PasswordManagerClient* client);
~CredentialManagerImpl() override;
- void BindRequest(mojom::CredentialManagerRequest request);
+ void BindRequest(mojom::CredentialManagerAssociatedRequest request);
+ bool HasBinding() const;
+ void DisconnectBinding();
// mojom::CredentialManager methods:
void Store(const CredentialInfo& credential, StoreCallback callback) override;
@@ -97,7 +99,7 @@ class CredentialManagerImpl
std::unique_ptr<CredentialManagerPendingPreventSilentAccessTask>
pending_require_user_mediation_;
- mojo::BindingSet<mojom::CredentialManager> bindings_;
+ mojo::AssociatedBinding<mojom::CredentialManager> binding_;
base::WeakPtrFactory<CredentialManagerImpl> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698