Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: content/public/common/presentation_connection_message.h

Issue 2947403004: [MediaRouter] Replace RouteMessage with PresentationConnectionMessage (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/presentation_connection_message.h
diff --git a/content/public/common/presentation_connection_message.h b/content/public/common/presentation_connection_message.h
index d9130c13860f1f0ed32a54a23a2eda036669f004..2c20d2573e96b94c59201ed1fb49f957413654f2 100644
--- a/content/public/common/presentation_connection_message.h
+++ b/content/public/common/presentation_connection_message.h
@@ -26,17 +26,22 @@ struct CONTENT_EXPORT PresentationConnectionMessage {
// Constructs a new, untyped message (for Mojo). These messages are not valid
// and exactly one of |message| or |data| must be set.
PresentationConnectionMessage();
- // PCM is a move-only type.
- PresentationConnectionMessage(PresentationConnectionMessage&& other);
+ // Copy constructor / assignment are necessary due to MediaRouter allowing
+ // multiple RouteMessageObserver instances per MediaRoute.
+ PresentationConnectionMessage(const PresentationConnectionMessage& other);
+ PresentationConnectionMessage(PresentationConnectionMessage&& other) noexcept;
// Constructs a text message from |message|.
explicit PresentationConnectionMessage(std::string message);
// Constructs a binary message from |data|.
explicit PresentationConnectionMessage(std::vector<uint8_t> data);
+
~PresentationConnectionMessage();
bool is_binary() const;
bool operator==(const PresentationConnectionMessage& other) const;
+ PresentationConnectionMessage& operator=(
+ const PresentationConnectionMessage& other);
PresentationConnectionMessage& operator=(
PresentationConnectionMessage&& other);
« no previous file with comments | « chrome/common/media_router/route_message.cc ('k') | content/public/common/presentation_connection_message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698