Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Side by Side Diff: chrome/browser/media/android/router/media_router_android.cc

Issue 2947403004: [MediaRouter] Replace RouteMessage with PresentationConnectionMessage (Closed)
Patch Set: Addressed Takumi's comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/android/router/media_router_android.h" 5 #include "chrome/browser/media/android/router/media_router_android.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/guid.h" 10 #include "base/guid.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "chrome/browser/android/tab_android.h" 13 #include "chrome/browser/android/tab_android.h"
14 #include "chrome/browser/media/router/media_routes_observer.h" 14 #include "chrome/browser/media/router/media_routes_observer.h"
15 #include "chrome/browser/media/router/media_sinks_observer.h" 15 #include "chrome/browser/media/router/media_sinks_observer.h"
16 #include "chrome/browser/media/router/route_message_observer.h" 16 #include "chrome/browser/media/router/route_message_observer.h"
17 #include "chrome/common/media_router/route_message.h"
18 #include "chrome/common/media_router/route_request_result.h" 17 #include "chrome/common/media_router/route_request_result.h"
19 #include "content/public/browser/browser_context.h" 18 #include "content/public/browser/browser_context.h"
19 #include "content/public/common/presentation_connection_message.h"
20 #include "url/gurl.h" 20 #include "url/gurl.h"
21 21
22 namespace media_router { 22 namespace media_router {
23 23
24 MediaRouterAndroid::MediaRouteRequest::MediaRouteRequest( 24 MediaRouterAndroid::MediaRouteRequest::MediaRouteRequest(
25 const MediaSource& source, 25 const MediaSource& source,
26 const std::string& presentation_id, 26 const std::string& presentation_id,
27 std::vector<MediaRouteResponseCallback> callbacks) 27 std::vector<MediaRouteResponseCallback> callbacks)
28 : media_source(source), 28 : media_source(source),
29 presentation_id(presentation_id), 29 presentation_id(presentation_id),
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 std::move(*callback).Run(success); 310 std::move(*callback).Run(success);
311 message_callbacks_.Remove(callback_id); 311 message_callbacks_.Remove(callback_id);
312 } 312 }
313 313
314 void MediaRouterAndroid::OnMessage(const MediaRoute::Id& route_id, 314 void MediaRouterAndroid::OnMessage(const MediaRoute::Id& route_id,
315 const std::string& message) { 315 const std::string& message) {
316 auto it = message_observers_.find(route_id); 316 auto it = message_observers_.find(route_id);
317 if (it == message_observers_.end()) 317 if (it == message_observers_.end())
318 return; 318 return;
319 319
320 std::vector<RouteMessage> messages(1); 320 std::vector<content::PresentationConnectionMessage> messages(1);
mark a. foltz 2017/06/28 07:29:53 Does messages({message}) work?
imcheng 2017/06/29 08:21:08 Yeah uniform initialization should work. I will us
321 messages.front().type = RouteMessage::TEXT; 321 messages.front().message = message;
322 messages.front().text = message;
323 for (auto& observer : *it->second.get()) 322 for (auto& observer : *it->second.get())
324 observer.OnMessagesReceived(messages); 323 observer.OnMessagesReceived(messages);
325 } 324 }
326 325
327 void MediaRouterAndroid::RemoveRoute(const MediaRoute::Id& route_id) { 326 void MediaRouterAndroid::RemoveRoute(const MediaRoute::Id& route_id) {
328 for (auto it = active_routes_.begin(); it != active_routes_.end(); ++it) 327 for (auto it = active_routes_.begin(); it != active_routes_.end(); ++it)
329 if (it->media_route_id() == route_id) { 328 if (it->media_route_id() == route_id) {
330 active_routes_.erase(it); 329 active_routes_.erase(it);
331 break; 330 break;
332 } 331 }
333 332
334 for (auto& observer : routes_observers_) 333 for (auto& observer : routes_observers_)
335 observer.OnRoutesUpdated(active_routes_, std::vector<MediaRoute::Id>()); 334 observer.OnRoutesUpdated(active_routes_, std::vector<MediaRoute::Id>());
336 } 335 }
337 336
338 } // namespace media_router 337 } // namespace media_router
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/media/cast_remoting_connector.h » ('j') | chrome/browser/media/cast_remoting_connector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698