Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2947383002: Put attribute before function name instead of after, as required by GCC (Closed)

Created:
3 years, 6 months ago by kwiberg-webrtc
Modified:
3 years, 5 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1, marxin.liska_gmail.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Put attribute before function name instead of after, as required by GCC As suggested by marxin.liska@gmail.com in bug 7857. BUG=webrtc:7857 Review-Url: https://codereview.webrtc.org/2947383002 Cr-Commit-Position: refs/heads/master@{#18757} Committed: https://chromium.googlesource.com/external/webrtc/+/d3cf0476b4c7923b6c0b8d25ce85769f6686b794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M webrtc/common_audio/vad/vad_core.c View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/entropy_coding.c View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/source/lattice.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kwiberg-webrtc
3 years, 5 months ago (2017-06-26 01:14:28 UTC) #7
kjellander_webrtc
lgtm I triggered the new linux_gcc_rel and it's happy (but it should have been before ...
3 years, 5 months ago (2017-06-26 06:06:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2947383002/1
3 years, 5 months ago (2017-06-26 08:10:51 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 08:32:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d3cf0476b4c7923b6c0b8d25c...

Powered by Google App Engine
This is Rietveld 408576698