Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2947363003: Avoid a crash if an initializing formal appears in the wrong context. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid a crash if an initializing formal appears in the wrong context. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/82561d8fa764a5481a54e600ba8df290300b3862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
Test case is still pending (see https://codereview.chromium.org/2955443002/). Once that lands I'll update this CL to ...
3 years, 6 months ago (2017-06-22 19:39:22 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-22 19:59:11 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-23 18:03:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82561d8fa764a5481a54e600ba8df290300b3862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698