Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc

Issue 2947283002: Unit-testing AnswerCardSearchProvider. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc
diff --git a/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc b/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc
index 3a04719a13fe3f206c67a82dd8f09193515052ce..17b4cef8b67806bd34bdfd16528ba414e3f9d2ad 100644
--- a/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc
+++ b/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc
@@ -11,10 +11,7 @@
#include "base/metrics/user_metrics.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/app_list/search/answer_card/answer_card_result.h"
-#include "chrome/browser/ui/browser_navigator.h"
-#include "chrome/browser/ui/browser_navigator_params.h"
#include "content/public/browser/navigation_handle.h"
-#include "content/public/browser/page_navigator.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_status_code.h"
#include "ui/app_list/app_list_features.h"
@@ -104,30 +101,6 @@ void AnswerCardSearchProvider::UpdatePreferredSize(const gfx::Size& pref_size) {
}
}
-content::WebContents* AnswerCardSearchProvider::OpenURLFromTab(
- const content::OpenURLParams& params) {
- // Open the user-clicked link in the browser taking into account the requested
- // disposition.
- chrome::NavigateParams new_tab_params(profile_, params.url,
- params.transition);
-
- new_tab_params.disposition = params.disposition;
-
- if (params.disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB) {
- // When the user asks to open a link as a background tab, we show an
- // activated window with the new activated tab after the user closes the
- // launcher. So it's "background" relative to the launcher itself.
- new_tab_params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
- new_tab_params.window_action = chrome::NavigateParams::SHOW_WINDOW_INACTIVE;
- }
-
- chrome::Navigate(&new_tab_params);
-
- base::RecordAction(base::UserMetricsAction("SearchAnswer_OpenedUrl"));
-
- return new_tab_params.target_contents;
-}
-
void AnswerCardSearchProvider::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
if (navigation_handle->GetURL() != current_request_url_) {

Powered by Google App Engine
This is Rietveld 408576698