Issue 2947243002: Revert "Load service isolate from a .dill file."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2947243002: Revert "Load service isolate from a .dill file." (Closed)

Created:
3 years, 6 months ago by sivachandra

Modified:
3 years, 6 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Load service isolate from a .dill file." This reverts commit b0c2a382ca70bc0f2270e4b8c7ccc76167f256cc as the vm-kernel mac bots are unhappy. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/e90aa9cb5f03c017c1e5dbc2fa13eebc9c550453

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -92 lines)			Patch
M	runtime/bin/dfe.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/bin/dfe.cc	View	4 chunks	+1 line, -21 lines	0 comments	Download
M	runtime/bin/main.cc	View	5 chunks	+29 lines, -63 lines	0 comments	Download

Total messages: 5 (2 generated)

sivachandra

The vm kernel mac builders are unhappy. I suspect that calling Dart_ReadKernelBinary before calling Dart_Initialize ...

3 years, 6 months ago (2017-06-21 20:24:47 UTC) #2

sivachandra

3 years, 6 months ago (2017-06-21 20:46:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e90aa9cb5f03c017c1e5dbc2fa13eebc9c550453 (presubmit successful).