Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3983)

Unified Diff: chrome/test/data/extensions/api_test/window_open/argument_overflow/test.js

Issue 2947223003: [Extensions Bindings] Consider argument type more in signature parsing (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/bindings/api_signature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/window_open/argument_overflow/test.js
diff --git a/chrome/test/data/extensions/api_test/window_open/argument_overflow/test.js b/chrome/test/data/extensions/api_test/window_open/argument_overflow/test.js
index 0b99bc262c0036f081a7d780c7c2e8e1fd7bec24..20fe73228352992e94e23a40345912bb58af4f25 100644
--- a/chrome/test/data/extensions/api_test/window_open/argument_overflow/test.js
+++ b/chrome/test/data/extensions/api_test/window_open/argument_overflow/test.js
@@ -6,8 +6,12 @@ function check_overflow_check(value) {
try {
chrome.windows.create({ "left": value }, function() { });
} catch (e) {
- chrome.test.assertTrue(e.message.indexOf(
- "Value must fit in a 32-bit signed integer.") != -1);
+ var jsBindingsError = 'Value must fit in a 32-bit signed integer.';
+ var nativeBindingsError = 'Invalid type: expected integer, found number.';
+ chrome.test.assertTrue(
+ e.message.indexOf(jsBindingsError) != -1 ||
+ e.message.indexOf(nativeBindingsError) != -1,
+ e.message);
chrome.test.succeed();
return;
}
« no previous file with comments | « no previous file | extensions/renderer/bindings/api_signature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698