[Extensions Bindings] Consider argument type more in signature parsing

extensions/renderer/bindings/argument_spec.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_BINDINGS_ARGUMENT_SPEC_H_
 #define EXTENSIONS_RENDERER_BINDINGS_ARGUMENT_SPEC_H_
 
 #include <map>
 #include <memory>
 #include <set>
@@ skipping 32 matching lines @@
  public:
   using PropertiesMap = std::map<std::string, std::unique_ptr<ArgumentSpec>>;
 
   // Reads the description from |value| and sets associated fields.
   // TODO(devlin): We should strongly think about generating these instead of
   // populating them at runtime.
   explicit ArgumentSpec(const base::Value& value);
   explicit ArgumentSpec(ArgumentType type);
   ~ArgumentSpec();
 
+  // Returns true if the given |value| is of the correct type to match this
+  // spec. If it is not, populates |error|.
+  bool IsCorrectType(v8::Local<v8::Value> value,
+                     const APITypeReferenceMap& refs,
+                     std::string* error) const;
+
   // Returns true if the passed |value| matches this specification. If
   // |out_value| is non-null, converts the value to a base::Value and populates
   // |out_value|. Otherwise, no conversion is performed.
   bool ParseArgument(v8::Local<v8::Context> context,
                      v8::Local<v8::Value> value,
                      const APITypeReferenceMap& refs,
                      std::unique_ptr<base::Value>* out_value,
                      std::string* error) const;
 
   // Returns a type name for this argument. Note: This should only be used to
@@ skipping 23 matching lines @@
   }
   void set_additional_properties(
       std::unique_ptr<ArgumentSpec> additional_properties) {
     additional_properties_ = std::move(additional_properties);
   }
 
  private:
   // Initializes this object according to |type_string| and |dict|.
   void InitializeType(const base::DictionaryValue* dict);
 
-  // Returns true if this argument refers to a fundamental type.
-  bool IsFundamentalType() const;
-
   // Conversion functions. These should only be used if the spec is of the given
   // type (otherwise, they will DCHECK).
   bool ParseArgumentToFundamental(v8::Local<v8::Context> context,
                                   v8::Local<v8::Value> value,
                                   std::unique_ptr<base::Value>* out_value,
                                   std::string* error) const;
   bool ParseArgumentToObject(v8::Local<v8::Context> context,
                              v8::Local<v8::Object> object,
                              const APITypeReferenceMap& refs,
                              std::unique_ptr<base::Value>* out_value,
@@ skipping 64 matching lines @@
   // to allow the API to pass an object with arbitrary properties. Only
   // applicable for ArgumentType::OBJECT.
   std::unique_ptr<ArgumentSpec> additional_properties_;
 
   DISALLOW_COPY_AND_ASSIGN(ArgumentSpec);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_BINDINGS_ARGUMENT_SPEC_H_