Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: pkg/analysis_server/test/src/plugin/plugin_locator_test.dart

Issue 2947153002: Disable finding plugin locations in the pubspec (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/plugin/plugin_locator.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'package:analysis_server/src/plugin/plugin_locator.dart'; 5 import 'package:analysis_server/src/plugin/plugin_locator.dart';
6 import 'package:analyzer/file_system/memory_file_system.dart'; 6 import 'package:analyzer/file_system/memory_file_system.dart';
7 import 'package:test/test.dart'; 7 import 'package:test/test.dart';
8 import 'package:test_reflective_loader/test_reflective_loader.dart'; 8 import 'package:test_reflective_loader/test_reflective_loader.dart';
9 9
10 main() { 10 main() {
(...skipping 10 matching lines...) Expand all
21 String defaultDirPath; 21 String defaultDirPath;
22 PluginLocator locator; 22 PluginLocator locator;
23 23
24 void setUp() { 24 void setUp() {
25 resourceProvider = new MemoryResourceProvider(); 25 resourceProvider = new MemoryResourceProvider();
26 packageRoot = resourceProvider.convertPath('/package'); 26 packageRoot = resourceProvider.convertPath('/package');
27 resourceProvider.newFolder(packageRoot); 27 resourceProvider.newFolder(packageRoot);
28 locator = new PluginLocator(resourceProvider); 28 locator = new PluginLocator(resourceProvider);
29 } 29 }
30 30
31 @failingTest
31 void test_findPlugin_inPubspec_defaultDir() { 32 void test_findPlugin_inPubspec_defaultDir() {
33 // Support for specifying plugin locations in the pubspec is temporarily
34 // disabled.
32 String dirPath = _createPubspecWithKey(); 35 String dirPath = _createPubspecWithKey();
33 _createDefaultDir(); 36 _createDefaultDir();
34 expect(locator.findPlugin(packageRoot), dirPath); 37 expect(locator.findPlugin(packageRoot), dirPath);
35 } 38 }
36 39
40 @failingTest
37 void test_findPlugin_inPubspec_noDefaultDir() { 41 void test_findPlugin_inPubspec_noDefaultDir() {
42 // Support for specifying plugin locations in the pubspec is temporarily
43 // disabled.
38 String dirPath = _createPubspecWithKey(); 44 String dirPath = _createPubspecWithKey();
39 expect(locator.findPlugin(packageRoot), dirPath); 45 expect(locator.findPlugin(packageRoot), dirPath);
40 } 46 }
41 47
42 void test_findPlugin_noPubspec_defaultDir() { 48 void test_findPlugin_noPubspec_defaultDir() {
43 _createDefaultDir(); 49 _createDefaultDir();
44 expect(locator.findPlugin(packageRoot), defaultDirPath); 50 expect(locator.findPlugin(packageRoot), defaultDirPath);
45 } 51 }
46 52
47 void test_findPlugin_noPubspec_noDefaultDir() { 53 void test_findPlugin_noPubspec_noDefaultDir() {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 resourceProvider.newFolder(nonDefaultPath); 87 resourceProvider.newFolder(nonDefaultPath);
82 return nonDefaultPath; 88 return nonDefaultPath;
83 } 89 }
84 90
85 void _createPubspecWithoutKey() { 91 void _createPubspecWithoutKey() {
86 _createPubspec(''' 92 _createPubspec('''
87 name: test_project 93 name: test_project
88 '''); 94 ''');
89 } 95 }
90 } 96 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/lib/src/plugin/plugin_locator.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698