Issue 2947143002: Revert "VM(RegExp): Allow OSR optimization of RegExp :matcher functions."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2947143002: Revert "VM(RegExp): Allow OSR optimization of RegExp :matcher functions." (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov

Modified:
3 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "VM(RegExp): Allow OSR optimization of RegExp :matcher functions." This reverts commit d87cc52c3ee791e4dff9136c5c80353deb0f36a3. TBR=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/8d583bde5bbc0095fe305ed4cc4d312aeb1405a0

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -62 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	3 chunks	+2 lines, -20 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	runtime/vm/regexp.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/regexp.cc	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	runtime/vm/regexp_assembler.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/regexp_assembler_ir.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/regexp_assembler_ir.cc	View	4 chunks	+5 lines, -13 lines	0 comments	Download

Total messages: 2 (1 generated)

Dmitry Stefantsov

3 years, 6 months ago (2017-06-21 12:17:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8d583bde5bbc0095fe305ed4cc4d312aeb1405a0 (presubmit successful).