Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2947113002: Implement API for shorthand properties "border-spacing", "columns" and "offset". (Closed)

Created:
3 years, 6 months ago by Jia
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement API for shorthand properties "border-spacing", "columns" and "offset". This cl contains the following * Implemented parseShorthand methods for the three shorthand properties indicated in the title of the cl. * Moved ConsumeOffsetRotate into CSSPropertyOffsetRotateUtils file. - This function is also used by "offset-rotate". * Changed CSSPropertyParser to use API for the three properties. Also - Removed functions that are no longer needed because of API impl. * Updated BUILD files and json files to include the new API files. Diff: https://gist.github.com/27ed543411b364127b3fc3a3c5e02343/revisions Review-Url: https://codereview.chromium.org/2947113002 Cr-Commit-Position: refs/heads/master@{#481452} Committed: https://chromium.googlesource.com/chromium/src/+/d90fcdc0b6810e28ed0970f76c69583cb686c90a

Patch Set 1 #

Patch Set 2 : Remove unused header files and ConsumeFlex from CSSPropertyParser.cpp #

Total comments: 4

Patch Set 3 : Removed two unused header files from CSSPropertyParser.cpp. #

Messages

Total messages: 15 (8 generated)
Jia
3 years, 6 months ago (2017-06-21 05:50:30 UTC) #4
Bugs Nash
lgtm with nit https://codereview.chromium.org/2947113002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/2947113002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode37 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:37: #include "core/css/properties/CSSPropertyAPIOffsetAnchor.h" should be able to ...
3 years, 6 months ago (2017-06-21 23:47:35 UTC) #5
Jia
Thanks for the review! https://codereview.chromium.org/2947113002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/2947113002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode37 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:37: #include "core/css/properties/CSSPropertyAPIOffsetAnchor.h" On 2017/06/21 23:47:34, ...
3 years, 6 months ago (2017-06-22 00:16:50 UTC) #6
Jia
3 years, 6 months ago (2017-06-22 00:17:13 UTC) #8
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-22 03:18:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947113002/40001
3 years, 6 months ago (2017-06-22 03:20:09 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 05:36:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d90fcdc0b6810e28ed0970f76c69...

Powered by Google App Engine
This is Rietveld 408576698