Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: device/bluetooth/dbus/bluetooth_device_client.cc

Issue 2947083002: Replace dbus::BluetoothDeviceClient names with constants from cros_system_api. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/dbus/bluetooth_device_client.cc
diff --git a/device/bluetooth/dbus/bluetooth_device_client.cc b/device/bluetooth/dbus/bluetooth_device_client.cc
index 142a72ba8f7e3df326c66cf57e21fbccbe7f205f..c79cba40f642380048ecf931375eb9877bffa222 100644
--- a/device/bluetooth/dbus/bluetooth_device_client.cc
+++ b/device/bluetooth/dbus/bluetooth_device_client.cc
@@ -444,11 +444,9 @@ class BluetoothDeviceClientImpl : public BluetoothDeviceClient,
return;
}
- // TODO(crbug.com/725367): Use constants in cros_system_api once it is
- // rolled.
dbus::MethodCall method_call(
bluetooth_plugin_device::kBluetoothPluginInterface,
- "SetLEConnectionParameters");
+ bluetooth_plugin_device::kSetLEConnectionParameters);
dbus::MessageWriter writer(&method_call);
dbus::MessageWriter dict_writer(nullptr);
@@ -457,7 +455,9 @@ class BluetoothDeviceClientImpl : public BluetoothDeviceClient,
{
dbus::MessageWriter dict_entry_writer(nullptr);
dict_writer.OpenDictEntry(&dict_entry_writer);
- dict_entry_writer.AppendString("MinimumConnectionInterval");
+ dict_entry_writer.AppendString(
+ bluetooth_plugin_device::
+ kLEConnectionParameterMinimumConnectionInterval);
dict_entry_writer.AppendUint16(conn_params.min_connection_interval);
dict_writer.CloseContainer(&dict_entry_writer);
}
@@ -465,7 +465,9 @@ class BluetoothDeviceClientImpl : public BluetoothDeviceClient,
{
dbus::MessageWriter dict_entry_writer(nullptr);
dict_writer.OpenDictEntry(&dict_entry_writer);
- dict_entry_writer.AppendString("MaximumConnectionInterval");
+ dict_entry_writer.AppendString(
+ bluetooth_plugin_device::
+ kLEConnectionParameterMaximumConnectionInterval);
dict_entry_writer.AppendUint16(conn_params.max_connection_interval);
dict_writer.CloseContainer(&dict_entry_writer);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698