Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/about_flags.cc

Issue 2947073002: Add chrome://flag to enable the Stale Previews timestamp (Closed)
Patch Set: add params Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index aa43d547c4fc76ef8ef63763e4abfdf917e7a548..f111f888e5750ab381396ac73448c2ebbf4457c8 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1031,6 +1031,15 @@ const FeatureEntry::FeatureVariation kDataReductionMainMenuFeatureVariations[] =
arraysize(kPersistentMenuItemEnabled), nullptr}};
#endif // OS_ANDROID
+const FeatureEntry::FeatureParam kStalePreviewsTimestampParams[] = {
+ {"min_staleness_in_minutes", "2"},
+ {"max_staleness_in_minutes", "1440"}};
+
+const FeatureEntry::FeatureVariation
+ kStalePreviewsTimestampFeatureVariations[] = {
+ {"(with staleness params)", kStalePreviewsTimestampParams,
+ arraysize(kStalePreviewsTimestampParams), nullptr}};
+
const FeatureEntry::Choice kEnableHeapProfilingChoices[] = {
{flags_ui::kGenericExperimentChoiceDisabled, "", ""},
{flag_descriptions::kEnableHeapProfilingModePseudo,
@@ -1956,6 +1965,12 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kEnableDataReductionProxyLitePageDescription, kOsAll,
SINGLE_VALUE_TYPE(
data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)},
+ {"enable-stale-previews-timestamp",
+ flag_descriptions::kEnableStalePreviewsName,
+ flag_descriptions::kEnableStalePreviewsDescription, kOsAll,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(previews::features::kStalePreviewsTimestamp,
megjablon 2017/06/21 00:25:07 Is there any way to add the params for a feature u
Alexei Svitkine (slow) 2017/06/22 16:29:21 Can you simply specify default values for params i
megjablon 2017/06/22 20:43:22 Done.
+ kStalePreviewsTimestampFeatureVariations,
+ "StalePreviewsTimestamp")},
{"enable-data-reduction-proxy-server-experiment",
flag_descriptions::kEnableDataReductionProxyServerExperimentName,
flag_descriptions::kEnableDataReductionProxyServerExperimentDescription,
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698