Add chrome://flag to enable the Stale Previews timestamp

Add chrome://flag to enable the Stale Previews timestamp

BUG=718643

[megjablon, 2017-06-21 00:25:06]

megjablon@chromium.org changed reviewers:
+ asvitkine@chromium.org

[megjablon, 2017-06-21 00:25:07]

PTAL, thanks!

https://codereview.chromium.org/2947073002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2947073002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1971:
FEATURE_WITH_PARAMS_VALUE_TYPE(previews::features::kStalePreviewsTimestamp,
Is there any way to add the params for a feature under the Enabled group? It
doesn't make sense for us to have an Enabled group without the params in this
case.

[megjablon, 2017-06-22 02:07:50]

Description was changed from

==========
Add chrome://flag to enable the Stale Previews timestamp

BUG=718667
==========

to

==========
Add chrome://flag to enable the Stale Previews timestamp

BUG=718643
==========

[megjablon, 2017-06-22 02:10:06]

megjablon@chromium.org changed reviewers:
+ rkaplow@chromium.org

[megjablon, 2017-06-22 02:10:06]

+rkaplow since it seems like asvitkine is busy

[Alexei Svitkine (slow), 2017-06-22 16:29:21]

https://codereview.chromium.org/2947073002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2947073002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1971:
FEATURE_WITH_PARAMS_VALUE_TYPE(previews::features::kStalePreviewsTimestamp,
On 2017/06/21 00:25:07, megjablon wrote:
> Is there any way to add the params for a feature under the Enabled group? It
> doesn't make sense for us to have an Enabled group without the params in this
> case.

Can you simply specify default values for params in the code where you're
querying them?

[megjablon, 2017-06-22 20:43:00]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[megjablon, 2017-06-22 20:43:22]

megjablon@chromium.org changed reviewers:
+ tbansal@chromium.org

[megjablon, 2017-06-22 20:43:22]

https://codereview.chromium.org/2947073002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2947073002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:1971:
FEATURE_WITH_PARAMS_VALUE_TYPE(previews::features::kStalePreviewsTimestamp,
On 2017/06/22 16:29:21, Alexei Svitkine (very slow) wrote:
> On 2017/06/21 00:25:07, megjablon wrote:
> > Is there any way to add the params for a feature under the Enabled group? It
> > doesn't make sense for us to have an Enabled group without the params in
this
> > case.
> 
> Can you simply specify default values for params in the code where you're
> querying them?

Done.

[commit-bot: I haz the power, 2017-06-22 20:43:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-06-22 20:53:07]

This looks okay to me, but can we not just start the experiment for 100% dogfood
population instead of shipping this extra code?

[commit-bot: I haz the power, 2017-06-22 21:31:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 21:31:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[megjablon, 2017-06-22 23:16:35]

On 2017/06/22 20:53:07, tbansal1 wrote:
> This looks okay to me, but can we not just start the experiment for 100%
dogfood
> population instead of shipping this extra code?

Ok, since we're depending on the server to ramp this up, I'll just enable the
Finch config. I can land this later if need be.