Updated parser to produce error when trying to reinitialize final variables in class constructors. …

Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658.

BUG=
R=zra@google.com

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
Committed: https://github.com/dart-lang/sdk/commit/9755a98b003a09a0f3aa76b610bcf715e58b0baa

[bkonyi, 2017-06-20 21:18:56]

bkonyi@google.com changed reviewers:
+ zra@google.com

[bkonyi, 2017-06-20 21:18:57]

Same change that was submitted yesterday, but with (hopefully) corrected status
files.

[zra, 2017-06-20 21:24:40]

lgtm w/ issue references

https://codereview.chromium.org/2947043002/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/2947043002/diff/1/tests/co19/co19-runtime.sta...
tests/co19/co19-runtime.status:17:
Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02:
CompileTimeError
Are there issues to reference here?

https://codereview.chromium.org/2947043002/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/2947043002/diff/1/tests/language/language.sta...
tests/language/language.status:12: const_error_multiply_initialized_test/02:
CompileTimeError
ditto

[bkonyi, 2017-06-20 21:35:12]

Updated an additional test so I could remove some of the status file changes.
PTAL before I submit.

https://codereview.chromium.org/2947043002/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/2947043002/diff/1/tests/co19/co19-runtime.sta...
tests/co19/co19-runtime.status:17:
Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02:
CompileTimeError
On 2017/06/20 21:24:40, zra wrote:
> Are there issues to reference here?

Yes. Added issue #'s.

https://codereview.chromium.org/2947043002/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/2947043002/diff/1/tests/language/language.sta...
tests/language/language.status:12: const_error_multiply_initialized_test/02:
CompileTimeError
On 2017/06/20 21:24:40, zra wrote:
> ditto

I've since updated the multitest to expect CompileTimeError for tests 02 and 04,
so this isn't necessary anymore.

[zra, 2017-06-20 21:38:32]

lgtm

[bkonyi, 2017-06-20 21:40:45]

Description was changed from

==========
Updated parser to produce error when trying to reinitialize final variables in
class constructors. Fixes issue #29658.

BUG=

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
==========

to

==========
Updated parser to produce error when trying to reinitialize final variables in
class constructors. Fixes issue #29658.

BUG=
R=zra@google.com

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
Committed:
https://github.com/dart-lang/sdk/commit/9755a98b003a09a0f3aa76b610bcf715e58b0baa
==========

[bkonyi, 2017-06-20 21:40:47]

Committed patchset #2 (id:20001) manually as
9755a98b003a09a0f3aa76b610bcf715e58b0baa (presubmit successful).