Move eventlog_provider from //base/win to //chrome/common/win

base/win/BUILD.gn

Index: base/win/BUILD.gn
diff --git a/base/win/BUILD.gn b/base/win/BUILD.gn
index 21a489dd50b29de3a9f02a4d790e7d4796253d31..0c592b5a1472c70c29faf6bd0263057babc5a864 100644
--- a/base/win/BUILD.gn
+++ b/base/win/BUILD.gn
@@ -28,7 +28,7 @@ buildflag_header("base_win_features") {
 message_compiler("eventlog_messages") {
   visibility = [
     "//base:base",
-    ":eventlog_provider",
+    "//chrome:eventlog_provider",

[grt (UTC plus 2), 2017/06/21 09:30:44]

this still has a dependency on chrome in base. looking a bit deeper, i see that
base/win/eventlog_messages.mc and base/syslog_logging.cc both have chrome-ish
things in them. my preference is for base logging to provide a way to generate
events without knowing that it's being used for a browser. it's already set up
so that SYSLOG(severity) doesn't do anything until Chrome calls
SetEventSourceName to tell base logging the name of the event source. i think
this is a good pattern to follow. i think we could sensibly move
eventlog_messages into //chrome/common as well. this would require removing it
as a dep from //base:base, removing the #include of base/win/eventlog_messages.h
from syslog_logging.cc, and adding uint16_t category, uint32_t event_id
parameters (or WORD category, DWORD event_id) params to a gently-renamed
SetEventSourceName method. this allows the embedder of //base:base to completely
tell it "here's how i want you to report SYSLOG messages".

[proberge, 2017/06/21 19:10:05]

This isn't really a dependency (it's a visibility rule). 
Still, I think your suggested solution makes a lot of sense and I've implemented
it in patchset 3. If //chrome/common OWNERS are unhappy with the change we can
go back to patchset #1. 

   ]
 
   sources = [
@@ -39,29 +39,6 @@ message_compiler("eventlog_messages") {
   compile_generated_code = false
 }
 
-process_version_rc_template("eventlog_provider_dll_version") {
-  sources = [
-    "eventlog_provider.ver",
-  ]
-  output = "$target_gen_dir/eventlog_provider_dll_version.rc"
-}
-
-shared_library("eventlog_provider") {
-  sources = [
-    "$root_gen_dir/base/win/eventlog_messages.rc",
-    "eventlog_provider.cc",
-  ]
-
-  if (!is_asan) {
-    ldflags = [ "/NOENTRY" ]
-  }
-
-  deps = [
-    "//base/win:eventlog_messages",
-    "//base/win:eventlog_provider_dll_version",
-  ]
-}
-
 static_library("pe_image") {
   sources = [
     "pe_image.cc",