Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: base/BUILD.gn

Issue 2946983002: Move eventlog_provider from //base/win to //chrome/common/win (Closed)
Patch Set: Address review comments on #5 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | base/syslog_logging.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1384 "file_descriptor_store.h", 1384 "file_descriptor_store.h",
1385 "memory/shared_memory_helper.cc", 1385 "memory/shared_memory_helper.cc",
1386 "memory/shared_memory_helper.h", 1386 "memory/shared_memory_helper.h",
1387 "message_loop/message_pump_libevent.cc", 1387 "message_loop/message_pump_libevent.cc",
1388 "strings/string16.cc", 1388 "strings/string16.cc",
1389 ] 1389 ]
1390 1390
1391 deps += [ 1391 deps += [
1392 "//base/trace_event/etw_manifest:chrome_events_win", 1392 "//base/trace_event/etw_manifest:chrome_events_win",
1393 "//base/win:base_win_features", 1393 "//base/win:base_win_features",
1394 "//base/win:eventlog_messages",
1395 ] 1394 ]
1396 1395
1397 if (is_component_build) { 1396 if (is_component_build) {
1398 # Copy the VS runtime DLLs into the isolate so that they don't have to be 1397 # Copy the VS runtime DLLs into the isolate so that they don't have to be
1399 # preinstalled on the target machine. The debug runtimes have a "d" at 1398 # preinstalled on the target machine. The debug runtimes have a "d" at
1400 # the end. 1399 # the end.
1401 if (is_debug) { 1400 if (is_debug) {
1402 vcrt_suffix = "d" 1401 vcrt_suffix = "d"
1403 } else { 1402 } else {
1404 vcrt_suffix = "" 1403 vcrt_suffix = ""
(...skipping 1360 matching lines...) Expand 10 before | Expand all | Expand 10 after
2765 } 2764 }
2766 2765
2767 fuzzer_test("base_json_correctness_fuzzer") { 2766 fuzzer_test("base_json_correctness_fuzzer") {
2768 sources = [ 2767 sources = [
2769 "json/correctness_fuzzer.cc", 2768 "json/correctness_fuzzer.cc",
2770 ] 2769 ]
2771 deps = [ 2770 deps = [
2772 ":base", 2771 ":base",
2773 ] 2772 ]
2774 } 2773 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | base/syslog_logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698