Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: BUILD.gn

Issue 2946983002: Move eventlog_provider from //base/win to //chrome/common/win (Closed)
Patch Set: Address review comments on #5 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 group("chromium_builder_tests") { 714 group("chromium_builder_tests") {
715 testonly = true 715 testonly = true
716 deps = [] 716 deps = []
717 } 717 }
718 718
719 # TODO(GYP_GONE): Figure out if we really need this target or if there's 719 # TODO(GYP_GONE): Figure out if we really need this target or if there's
720 # some better way to specify things. 720 # some better way to specify things.
721 if (is_win) { 721 if (is_win) {
722 group("chrome_official_builder_no_unittests") { 722 group("chrome_official_builder_no_unittests") {
723 deps = [ 723 deps = [
724 "//base/win:eventlog_provider", 724 "//chrome/common/win:eventlog_provider",
725 "//chrome/installer/gcapi", 725 "//chrome/installer/gcapi",
726 "//chrome/installer/mini_installer", 726 "//chrome/installer/mini_installer",
727 "//cloud_print", 727 "//cloud_print",
728 "//cloud_print/virtual_driver/win/port_monitor:copy_gcp_portmon_binaries", 728 "//cloud_print/virtual_driver/win/port_monitor:copy_gcp_portmon_binaries",
729 "//components/policy:pack_policy_templates", 729 "//components/policy:pack_policy_templates",
730 "//courgette", 730 "//courgette",
731 "//courgette:copy_courgette_binaries", 731 "//courgette:copy_courgette_binaries",
732 "//remoting/webapp", 732 "//remoting/webapp",
733 "//tools/metrics:metrics_metadata", 733 "//tools/metrics:metrics_metadata",
734 ] 734 ]
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
1060 assert(target_name != "") # Mark as used. 1060 assert(target_name != "") # Mark as used.
1061 sources = invoker.actual_sources 1061 sources = invoker.actual_sources
1062 assert( 1062 assert(
1063 sources == invoker.actual_sources, 1063 sources == invoker.actual_sources,
1064 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1064 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1065 } 1065 }
1066 1066
1067 assert_valid_out_dir("_unused") { 1067 assert_valid_out_dir("_unused") {
1068 actual_sources = [ "$root_build_dir/foo" ] 1068 actual_sources = [ "$root_build_dir/foo" ]
1069 } 1069 }
OLDNEW
« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698