Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2946943002: Record static types in the desugaring of null-aware property gets. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record static types in the desugaring of null-aware property gets. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/eadfe2816b6513cdc85f1c99e45e589cda50f54c

Patch Set 1 #

Patch Set 2 : Fix inference of receiver type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/null_aware_property_get.dart.direct.expect View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/null_aware_property_get.dart.strong.expect View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-20 17:42:08 UTC) #2
Paul Berry
Whoops, hold off on this. It's doing the wrong thing. I'll let you know when ...
3 years, 6 months ago (2017-06-20 17:48:36 UTC) #3
Paul Berry
Ok, fixed. PTAL
3 years, 6 months ago (2017-06-20 18:18:38 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-20 18:22:22 UTC) #5
Paul Berry
3 years, 6 months ago (2017-06-20 18:29:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eadfe2816b6513cdc85f1c99e45e589cda50f54c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698