Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 294693002: Moved metrics_reporting_scheduler* to //components/metrics. (Closed)

Created:
6 years, 7 months ago by motek.
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Moved metrics_reporting_scheduler* to //components/metrics. Automove with some manual fixes. BUG=374214 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271676

Patch Set 1 #

Patch Set 2 : Re-synced with the tree. #

Patch Set 3 : Hopefully synced this time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -306 lines) Patch
D chrome/browser/metrics/metrics_reporting_scheduler.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/metrics/metrics_reporting_scheduler.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/browser/metrics/metrics_reporting_scheduler_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + components/metrics/metrics_reporting_scheduler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/metrics/metrics_reporting_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/metrics/metrics_reporting_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Ilya Sherman
LGTM, thanks :)
6 years, 7 months ago (2014-05-19 13:54:29 UTC) #1
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-19 13:54:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/294693002/1
6 years, 7 months ago (2014-05-19 13:54:47 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 17:46:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 17:54:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/20918)
6 years, 7 months ago (2014-05-19 17:54:38 UTC) #6
motek.
The CQ bit was checked by motek@chromium.org
6 years, 7 months ago (2014-05-20 08:31:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/294693002/20001
6 years, 7 months ago (2014-05-20 08:32:18 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 09:14:00 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 09:17:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/5712) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68593) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-20 09:17:58 UTC) #11
motek.
The CQ bit was checked by motek@chromium.org
6 years, 7 months ago (2014-05-20 11:22:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/294693002/40001
6 years, 7 months ago (2014-05-20 11:23:29 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 14:27:06 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 17:16:48 UTC) #15
Message was sent while issue was closed.
Change committed as 271676

Powered by Google App Engine
This is Rietveld 408576698