Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2946903002: Improve --print-ast printing of LetNode. (Closed)

Created:
3 years, 6 months ago by Kevin Millikin (Google)
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve --print-ast printing of LetNode. I was trying to debug an issue noticed that printing of LetNode is kind of useless. It didn't print the variables though they had references, which seems confusing, and it writes all the initializers and body nodes at the same nesting level which makes it impossible to see where one ends and the other begins. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/9d495064f7d5e6a25b1d221bde6858831ad98cbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -17 lines) Patch
M runtime/vm/ast_printer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/ast_printer.cc View 3 chunks +48 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 6 months ago (2017-06-20 14:43:58 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 6 months ago (2017-06-20 14:47:23 UTC) #3
Kevin Millikin (Google)
3 years, 6 months ago (2017-06-20 14:49:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d495064f7d5e6a25b1d221bde6858831ad98cbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698