MD Bookmarks: Deselect items when they are moved to a new folder

chrome/test/data/webui/md_bookmarks/reducers_test.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 suite('selection state', function() {
   var selection;
   var action;
 
   function select(items, anchor, clear, toggle) {
     return {
@@ skipping 88 matching lines @@
   });
 
   test('update anchor', function() {
     action = bookmarks.actions.updateAnchor('3');
     selection = bookmarks.SelectionState.updateSelection(selection, action);
 
     assertEquals('3', selection.anchor);
   });
 
   test('deselects items when they are deleted', function() {
-    var nodeMap = testTree(createFolder('0', [
-      createFolder(
-          '1',
-          [
-            createItem('2'),
-            createItem('3'),
-            createItem('4'),
-          ]),
-      createItem('5'),
-    ]));
+    var nodeMap = testTree(
+        createFolder(
+            '1',
+            [
+              createItem('2'),
+              createItem('3'),
+              createItem('4'),
+            ]),
+        createItem('5'),
+    );
 
     action = select(['2', '4', '5'], '4', true, false);
     selection = bookmarks.SelectionState.updateSelection(selection, action);
 
     action = bookmarks.actions.removeBookmark('1', '0', 0, nodeMap);
     selection = bookmarks.SelectionState.updateSelection(selection, action);
 
     assertDeepEquals(['5'], normalizeSet(selection.items));
     assertEquals(null, selection.anchor);
   });
+
+  test('deselects items when they are moved to a different folder', function() {
+    var nodeMap = testTree(
+        createFolder('1', []),
+        createItem('2'),
+        createItem('3'),
+    );
+
+    action = select(['2', '3'], '2', true, false);
+    selection = bookmarks.SelectionState.updateSelection(selection, action);
+
+    // Move item '2' from the 1st item in '0' to the 0th item in '1'.
+    action = bookmarks.actions.moveBookmark('2', '1', 0, '0', 1);

[calamity, 2017/06/22 05:35:34]

I feel like we should have made these objects. It's pretty hard to read the args
as is =\

[tsergeant, 2017/06/22 06:59:09]

Do you mean in general or just in this test?

This is kind of the worst case that we have. We could change this test to
directly construct the object, but I don't think it's bad enough to warrant it.

+    selection = bookmarks.SelectionState.updateSelection(selection, action);
+
+    assertDeepEquals(['3'], normalizeSet(selection.items));
+    assertEquals(null, selection.anchor);
+  });
 });
 
 suite('closed folder state', function() {
   var nodes;
   var closedFolders;
   var action;
 
   setup(function() {
     nodes = testTree(
         createFolder(
@@ skipping 302 matching lines @@
     state = bookmarks.reduceAction(state, action);
 
     action = bookmarks.actions.removeBookmark('2', '1', 0, state.nodes);
     state = bookmarks.reduceAction(state, action);
 
     // 2 and 3 should be removed, since 2 was deleted and 3 was a descendant of
     // 2.
     assertDeepEquals(['1'], state.search.results);
   });
 });