gyp/iconv.gyp - Issue 294683003: Since we're only using it on Linux now, just require poppler as a system dependency.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/iconv.gyp

Issue 294683003: Since we're only using it on Linux now, just require poppler as a system dependency. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: set -e Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 # GYP for iconv

2 #

3 # NOTE: WINDOWS BUILD ONLY.

4 # iconv should be native to Mac and Linux.

5 #

6 # Based on instructions found on http://www.codeproject.com/Articles/302012/How- to-Build-libiconv-with-Microsoft-Visual-Studio

7 # See the relevant README.chromium file for more information.

8

9 {

10 'variables': {

11 'skia_warnings_as_errors': 0,

12 },

13 'targets': [

14 {

15 'target_name': 'iconv',

16 'type': 'static_library',

17 'include_dirs' : [

18 '../third_party/externals/iconv/lib',

19 '../third_party/iconv/config',

20 ],

21 'sources': [

22 '../third_party/externals/iconv/lib/iconv.c',

23 '../third_party/externals/iconv/libcharset/lib/localcharset.c',

24 ],

25

26 'conditions': [

27 ['skia_os == "win"', {

28 'include_dirs': [

29 '../third_party/iconv/config/windows',

30 ],

31 'direct_dependent_settings': {

32 'include_dirs': [

33 '../third_party/iconv/config/windows',

34 ],

35 },

36 'defines': [

37 'LIBDIR',

38 ],

39 }],

40 ],

41 },

42 ],

43 }

OLD	NEW

« no previous file with comments | « gyp/gm.gyp ('k') | gyp/poppler.gyp » ('j') | no next file with comments »