Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 294683003: Since we're only using it on Linux now, just require poppler as a system dependency. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Since we're only using it on Linux now, just require poppler as a system dependency. The Ubuntu package needed is libpoppler-cpp-dev. iconv and fontconfig were only used as Poppler dependencies. bson_c is also unused. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14802

Patch Set 1 #

Patch Set 2 : reup #

Patch Set 3 : install_dependencies.sh #

Patch Set 4 : set -e #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17779 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D gyp/fontconfig.gyp View 1 chunk +0 lines, -199 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -1 line 0 comments Download
D gyp/iconv.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
M gyp/poppler.gyp View 1 chunk +12 lines, -232 lines 0 comments Download
D third_party/bson_c/APACHE-2.0.txt View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/bson_c/src/bson.h View 1 chunk +0 lines, -1036 lines 0 comments Download
D third_party/bson_c/src/bson.c View 1 chunk +0 lines, -1063 lines 0 comments Download
D third_party/bson_c/src/encoding.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/bson_c/src/encoding.c View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/bson_c/src/numbers.c View 1 chunk +0 lines, -127 lines 0 comments Download
D third_party/bson_c/test/bson_subobject_test.c View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/bson_c/test/bson_test.c View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/fontconfig/LICENSE View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/fontconfig/LICENSE.win View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/fontconfig/README.chromium View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/fontconfig/config/fc-case/fccase.h View 1 chunk +0 lines, -330 lines 0 comments Download
D third_party/fontconfig/config/fc-glyphname/fcglyphname.h View 1 chunk +0 lines, -781 lines 0 comments Download
D third_party/fontconfig/config/fc-lang/fclang.h View 1 chunk +0 lines, -4176 lines 0 comments Download
D third_party/fontconfig/config/mac/config.h.template View 1 chunk +0 lines, -369 lines 0 comments Download
D third_party/fontconfig/config/mac/fcstdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcalias.h View 1 chunk +0 lines, -390 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcaliastail.h View 1 chunk +0 lines, -440 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcftalias.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/fontconfig/config/mac/src/fcftaliastail.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/fontconfig/config/src/fcobjshash.h View 1 chunk +0 lines, -317 lines 0 comments Download
D third_party/fontconfig/config/windows/config.h View 1 chunk +0 lines, -243 lines 0 comments Download
D third_party/fontconfig/config/windows/dirent.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/fontconfig/config/windows/dirent.c View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/fontconfig/config/windows/fcstdint.h View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcalias.h View 1 chunk +0 lines, -368 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcaliastail.h View 1 chunk +0 lines, -738 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcftalias.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/fontconfig/config/windows/src/fcftaliastail.h View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/fontconfig/config/windows/unistd.h View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/fontconfig/process-template.py View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/iconv/LICENSE View 1 chunk +0 lines, -482 lines 0 comments Download
D third_party/iconv/README.chromium View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/iconv/config/aliases.h View 1 chunk +0 lines, -1719 lines 0 comments Download
D third_party/iconv/config/canonical.h View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/iconv/config/canonical_dos.h View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/iconv/config/canonical_local.h View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/iconv/config/flags.h View 1 chunk +0 lines, -157 lines 0 comments Download
D third_party/iconv/config/windows/config.h View 1 chunk +0 lines, -926 lines 0 comments Download
D third_party/iconv/config/windows/iconv.h View 1 chunk +0 lines, -244 lines 0 comments Download
D third_party/iconv/config/windows/localcharset.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/poppler/LICENSE View 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/poppler/README.chromium View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/poppler/config/linux/config.h View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/poppler/config/linux/poppler-config.h View 1 chunk +0 lines, -174 lines 0 comments Download
D third_party/poppler/config/mac/config.h View 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/poppler/config/mac/poppler-config.h View 1 chunk +0 lines, -174 lines 0 comments Download
D third_party/poppler/config/poppler-version.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/poppler/config/windows/config.h View 1 chunk +0 lines, -225 lines 0 comments Download
D third_party/poppler/config/windows/poppler-config.h View 1 chunk +0 lines, -173 lines 0 comments Download
M tools/install_dependencies.sh View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
mtklein
6 years, 7 months ago (2014-05-19 18:59:43 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-19 19:00:11 UTC) #2
mtklein
On 2014/05/19 19:00:11, reed1 wrote: > lgtm Ravi, Eric, can you guys apt-get install libpoppler-cpp-dev ...
6 years, 7 months ago (2014-05-19 20:08:35 UTC) #3
rmistry
On 2014/05/19 20:08:35, mtklein wrote: > On 2014/05/19 19:00:11, reed1 wrote: > > lgtm > ...
6 years, 7 months ago (2014-05-19 20:27:57 UTC) #4
borenet
On 2014/05/19 20:27:57, rmistry wrote: > On 2014/05/19 20:08:35, mtklein wrote: > > On 2014/05/19 ...
6 years, 7 months ago (2014-05-19 20:42:24 UTC) #5
rmistry
On 2014/05/19 20:42:24, borenet wrote: > On 2014/05/19 20:27:57, rmistry wrote: > > On 2014/05/19 ...
6 years, 7 months ago (2014-05-19 20:50:36 UTC) #6
hal.canary
Which version of libpoppler-cpp-dev do we depend on?
6 years, 7 months ago (2014-05-19 20:50:43 UTC) #7
rmistry
On 2014/05/19 20:50:36, rmistry wrote: > On 2014/05/19 20:42:24, borenet wrote: > > On 2014/05/19 ...
6 years, 7 months ago (2014-05-19 20:52:56 UTC) #8
rmistry
On 2014/05/19 20:52:56, rmistry wrote: > On 2014/05/19 20:50:36, rmistry wrote: > > On 2014/05/19 ...
6 years, 7 months ago (2014-05-19 20:53:44 UTC) #9
mtklein
> > > Completed installation on all 75 GCE chromecompute bots. > > > > ...
6 years, 7 months ago (2014-05-19 21:02:00 UTC) #10
mtklein
On 2014/05/19 21:02:00, mtklein wrote: > > > > Completed installation on all 75 GCE ...
6 years, 7 months ago (2014-05-19 21:15:36 UTC) #11
rmistry
On 2014/05/19 21:15:36, mtklein wrote: > On 2014/05/19 21:02:00, mtklein wrote: > > > > ...
6 years, 7 months ago (2014-05-20 12:16:37 UTC) #12
borenet
On 2014/05/20 12:16:37, rmistry wrote: > On 2014/05/19 21:15:36, mtklein wrote: > > On 2014/05/19 ...
6 years, 7 months ago (2014-05-20 12:38:09 UTC) #13
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 15:02:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/294683003/60001
6 years, 7 months ago (2014-05-20 15:02:30 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:08:03 UTC) #16
Message was sent while issue was closed.
Change committed as 14802

Powered by Google App Engine
This is Rietveld 408576698