chrome/browser/ui/views/frame/browser_view.cc - Issue 2946813002: Bookmark disappear first when closing browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2946813002: Bookmark disappear first when closing browser (Closed)

Patch Set: Add unittest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index c75bcc68df0366df940e2b8a0ed9b782b2f21c7a..7f26738e74dc2e0d1c6b95e7314562986390cadc 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2198,7 +2198,7 @@ bool BrowserView::MaybeShowBookmarkBar(WebContents* contents) {

else

new_parent = top_container_;

}

- if (new_parent != bookmark_bar_view_->parent()) {

+ if (new_parent != nullptr && new_parent != bookmark_bar_view_->parent()) {

SetBookmarkBarParent(new_parent);

needs_layout = true;

}

« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view_unittest.cc » ('j') | no next file with comments »