chrome/browser/ui/views/frame/browser_view.cc - Issue 2946813002: Bookmark disappear first when closing browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2946813002: Bookmark disappear first when closing browser (Closed)

Patch Set: Return back to earlier fix Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index c75bcc68df0366df940e2b8a0ed9b782b2f21c7a..a6fb085102bfbd3972903b8b59fbd73435136ff4 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2170,7 +2170,7 @@ ContentsLayoutManager* BrowserView::GetContentsLayoutManager() const {

}

bool BrowserView::MaybeShowBookmarkBar(WebContents* contents) {

- bool show_bookmark_bar = contents &&

+ bool show_bookmark_bar =

browser_->SupportsWindowFeature(Browser::FEATURE_BOOKMARKBAR);

if (!show_bookmark_bar && !bookmark_bar_view_.get())

return false;

« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view_unittest.cc » ('j') | no next file with comments »