Bookmark disappear first when closing browser

chrome/browser/ui/views/frame/browser_view_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include "base/macros.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"
 #include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"
 #include "chrome/browser/ui/views/frame/top_container_view.h"
 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 #include "chrome/common/url_constants.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/views/controls/webview/webview.h"
@@ skipping 154 matching lines @@
   const ui::Accelerator kLocationRepeatAccel(
       ui::VKEY_L, kPlatformModifier | ui::EF_IS_REPEAT);
   EXPECT_FALSE(browser_view()->AcceleratorPressed(kLocationRepeatAccel));
 
   // A repeated Ctrl-Tab accelerator should be processed.
   const ui::Accelerator kNextTabRepeatAccel(
       ui::VKEY_TAB, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT);
   EXPECT_TRUE(browser_view()->AcceleratorPressed(kNextTabRepeatAccel));
 }
 
+// Test that the bookmark bar view's parent is not set to nullptr when closing
+// the browser. If the parent is set to nullptr, then the bookmark bar
+// disappears before the browser is closed, which looks weird.
+TEST_F(BrowserViewTest, BookmarkBarParentIsNotNullOnShutdown) {
+  BookmarkBarView::DisableAnimationsForTesting(true);
+
+  Browser* browser = browser_view()->browser();
+  TabStripModel* tab_strip_model = browser->tab_strip_model();
+  EXPECT_EQ(0, tab_strip_model->count());
+
+  AddTab(browser, GURL("about:blank"));
+  EXPECT_EQ(1, tab_strip_model->count());
+
+  BookmarkBarView* bookmark_bar = browser_view()->GetBookmarkBarView();
+  chrome::ExecuteCommand(browser, IDC_SHOW_BOOKMARK_BAR);
+  EXPECT_NE(nullptr, bookmark_bar->parent());
+
+  tab_strip_model->CloseWebContentsAt(tab_strip_model->active_index(), 0);
+  EXPECT_EQ(0, tab_strip_model->count());
+  EXPECT_NE(nullptr, bookmark_bar->parent());
+
+  BookmarkBarView::DisableAnimationsForTesting(false);
+}
+
 class BrowserViewHostedAppTest : public TestWithBrowserView {
  public:
   BrowserViewHostedAppTest() : TestWithBrowserView(Browser::TYPE_POPUP, true) {}
   ~BrowserViewHostedAppTest() override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BrowserViewHostedAppTest);
 };
 
 // Test basic layout for hosted apps.
@@ skipping 22 matching lines @@
       header_offset.y();
 
   // The web contents should be flush with the bottom of the header.
   EXPECT_EQ(bottom_of_header, contents_container->y());
 
   // The find bar should overlap the 1px header/web-contents separator at the
   // bottom of the header.
   EXPECT_LT(browser_view()->GetFindBarBoundingBox().y(),
             browser_view()->frame()->GetTopInset(false));
 }