Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2946783002: Simplify CommandOutput and friends. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify CommandOutput and friends. - Merge CommandOutputImpl and CommandOutput. There were no classes that implemented CommandOutput that didn't extend the Impl. - Remove "Impl" from the other class names. - Make stuff private when possible. Likewise final. - Other tiny style changes. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/556c0550bf8d791a4ae799892f186ea56b98c290

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into simplify-command-output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -226 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M tools/testing/dart/command.dart View 1 6 chunks +16 lines, -25 lines 0 comments Download
M tools/testing/dart/command_output.dart View 31 chunks +136 lines, -182 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 8 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 6 months ago (2017-06-19 21:23:48 UTC) #2
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-21 15:52:54 UTC) #3
Bob Nystrom
3 years, 6 months ago (2017-06-23 19:13:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
556c0550bf8d791a4ae799892f186ea56b98c290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698