Remove vmservice_patch.dart.

Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library.
This is being done because, the vmservice related libraries are
now compiled directly from source instead of from the "patched_sdk".
So, what is being compiled now does not have the vmservice_patch
applied. By removing the patch, we are removing the need to
artificially patch the vmservice library and making the
vmservice_io.dill complete.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b9bf4fcc48b402d4573659aa89ba8ac0c7ed7354

[sivachandra, 2017-06-19 22:13:40]

Description was changed from

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library.
==========

to

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library. This is being
done because, the vmservice related libraries are now compiled directly from
source instead of from the "patched_sdk". So, what is being compiled now does
not have the vmservice_patch applied. By removing the patch, we are removing the
need to artificially patch the vmservice library.
==========

[sivachandra, 2017-06-19 22:14:55]

Description was changed from

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library. This is being
done because, the vmservice related libraries are now compiled directly from
source instead of from the "patched_sdk". So, what is being compiled now does
not have the vmservice_patch applied. By removing the patch, we are removing the
need to artificially patch the vmservice library.
==========

to

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library. This is being
done because, the vmservice related libraries are now compiled directly from
source instead of from the "patched_sdk". So, what is being compiled now does
not have the vmservice_patch applied. By removing the patch, we are removing the
need to artificially patch the vmservice library and making the
vmservice_io.dill complete.
==========

[sivachandra, 2017-06-19 22:16:13]

sivachandra@google.com changed reviewers:
+ rmacnak@google.com

[sivachandra, 2017-06-19 22:16:13]

This CL removes the vmservice_patch as discussed offline.

[sivachandra, 2017-06-20 01:02:09]

Description was changed from

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library. This is being
done because, the vmservice related libraries are now compiled directly from
source instead of from the "patched_sdk". So, what is being compiled now does
not have the vmservice_patch applied. By removing the patch, we are removing the
need to artificially patch the vmservice library and making the
vmservice_io.dill complete.
==========

to

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library.
This is being done because, the vmservice related libraries are
now compiled directly from source instead of from the "patched_sdk".
So, what is being compiled now does not have the vmservice_patch
applied. By removing the patch, we are removing the need to
artificially patch the vmservice library and making the
vmservice_io.dill complete.
==========

[rmacnak, 2017-06-20 17:28:13]

lgtm

[sivachandra, 2017-06-20 19:24:20]

Description was changed from

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library.
This is being done because, the vmservice related libraries are
now compiled directly from source instead of from the "patched_sdk".
So, what is being compiled now does not have the vmservice_patch
applied. By removing the patch, we are removing the need to
artificially patch the vmservice library and making the
vmservice_io.dill complete.
==========

to

==========
Remove vmservice_patch.dart.

The code in the patch is now inlined into the vmservice library.
This is being done because, the vmservice related libraries are
now compiled directly from source instead of from the "patched_sdk".
So, what is being compiled now does not have the vmservice_patch
applied. By removing the patch, we are removing the need to
artificially patch the vmservice library and making the
vmservice_io.dill complete.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b9bf4fcc48b402d4573659aa89ba8ac0c7ed7354
==========

[sivachandra, 2017-06-20 19:24:22]

Committed patchset #1 (id:1) manually as
b9bf4fcc48b402d4573659aa89ba8ac0c7ed7354 (presubmit successful).

[zra, 2017-06-21 16:28:40]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2017-06-21 16:28:41]

Should this change also remove _vmservice_patch_paths_ in
runtime/vm/bootstrap.h?

[sivachandra, 2017-06-21 16:56:05]

On 2017/06/21 16:28:41, zra wrote:
> Should this change also remove _vmservice_patch_paths_ in
> runtime/vm/bootstrap.h?

Yes, it should have. But, it was more tricky than simply removing it.
Considering this change had the potential to disrupt of lot of them, I decided
to do this removal in a follow up CL so that this CL remains as simple as
possible.

[siva, 2017-06-21 17:14:26]

On 2017/06/21 16:56:05, sivachandra wrote:
> On 2017/06/21 16:28:41, zra wrote:
> > Should this change also remove _vmservice_patch_paths_ in
> > runtime/vm/bootstrap.h?
> 
> Yes, it should have. But, it was more tricky than simply removing it.
> Considering this change had the potential to disrupt of lot of them, I decided
> to do this removal in a follow up CL so that this CL remains as simple as
> possible.

Not sure if we should remove it as that would mean changing the generic
bootstrap processing loop and special case vmservice