Fix type inference of getters that "override" setters and vice versa.

Fix type inference of getters that "override" setters and vice versa.

Normally getters and setters are considered distinct and unrelated by
the type inference algorithm.  However, if a getter has no declared
type and doesn't override anything, then we fall back on inferring its
type from an inherited setter, and vice versa.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/be01632bc04770e523360a6d806c025be857da48

[Paul Berry, 2017-06-19 18:28:34]

paulberry@google.com changed reviewers:
+ ahe@google.com, kmillikin@google.com, sigmund@google.com

[Paul Berry, 2017-06-19 18:28:35]

Siggi to review front_end changes and do preliminary west coast review of kernel
changes (Konstantin is on vacation).
Peter or Kevin to do final review of kernel changes.

[Siggi Cherem (dart-lang), 2017-06-19 20:47:35]

lgtm

(although I'm not as familiar with the type-inference implementation, so I'll be
asking you some additional questions offline)

https://codereview.chromium.org/2946733003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
(right):

https://codereview.chromium.org/2946733003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart:169: //
TODO(paulberry): support dependencies on getters/setters too.
is the TODO now outdated? (it appears like here you are basically looking up a
dependency on a getter/setter.)

https://codereview.chromium.org/2946733003/diff/1/pkg/kernel/lib/class_hierar...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2946733003/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:139: /// callback parameter corresponds to
TODO(paulberry): ???.
nit: fix TODO :)

[Paul Berry, 2017-06-19 21:58:29]

https://codereview.chromium.org/2946733003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
(right):

https://codereview.chromium.org/2946733003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart:169: //
TODO(paulberry): support dependencies on getters/setters too.
On 2017/06/19 20:47:34, Siggi Cherem (dart-lang) wrote:
> is the TODO now outdated? (it appears like here you are basically looking up a
> dependency on a getter/setter.)

Yes, thanks.  TODO removed.

https://codereview.chromium.org/2946733003/diff/1/pkg/kernel/lib/class_hierar...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2946733003/diff/1/pkg/kernel/lib/class_hierar...
pkg/kernel/lib/class_hierarchy.dart:139: /// callback parameter corresponds to
TODO(paulberry): ???.
On 2017/06/19 20:47:34, Siggi Cherem (dart-lang) wrote:
> nit: fix TODO :)

Done.

[Paul Berry, 2017-06-20 12:34:36]

Description was changed from

==========
Fix type inference of getters that "override" setters and vice versa.

Normally getters and setters are considered distinct and unrelated by
the type inference algorithm.  However, if a getter has no declared
type and doesn't override anything, then we fall back on inferring its
type from an inherited setter, and vice versa.
==========

to

==========
Fix type inference of getters that "override" setters and vice versa.

Normally getters and setters are considered distinct and unrelated by
the type inference algorithm.  However, if a getter has no declared
type and doesn't override anything, then we fall back on inferring its
type from an inherited setter, and vice versa.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/be01632bc04770e523360a6d806c025be857da48
==========

[Paul Berry, 2017-06-20 12:34:37]

Committed patchset #2 (id:20001) manually as
be01632bc04770e523360a6d806c025be857da48 (presubmit successful).

[scheglov, 2017-06-26 20:29:11]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-26 20:29:12]

https://codereview.chromium.org/2946733003/diff/20001/pkg/kernel/lib/class_hi...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2946733003/diff/20001/pkg/kernel/lib/class_hi...
pkg/kernel/lib/class_hierarchy.dart:138: /// By default getters and setters are
overridden separately.  The [isSetter]
"By default getters and setters are overridden separately." does not seem useful
here.
This method is exactly for crossing getters and setters.

[Paul Berry, 2017-06-27 20:53:30]

https://codereview.chromium.org/2946733003/diff/20001/pkg/kernel/lib/class_hi...
File pkg/kernel/lib/class_hierarchy.dart (right):

https://codereview.chromium.org/2946733003/diff/20001/pkg/kernel/lib/class_hi...
pkg/kernel/lib/class_hierarchy.dart:138: /// By default getters and setters are
overridden separately.  The [isSetter]
On 2017/06/26 20:29:12, scheglov wrote:
> "By default getters and setters are overridden separately." does not seem
useful
> here.
> This method is exactly for crossing getters and setters.

Thanks!  https://codereview.chromium.org/2960033002/ should address this.