Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ui/accessibility/ax_node_data.cc

Issue 2946673003: Aria-details takes an ID reference, not an ID reference list (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/accessibility/ax_enums.idl ('k') | ui/accessibility/ax_tree_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/ax_node_data.cc
diff --git a/ui/accessibility/ax_node_data.cc b/ui/accessibility/ax_node_data.cc
index 1655b399f1e8abf31df1332113e954ce0fb68e58..35955d2dcef02b1d60424d38fd15b415ff251080 100644
--- a/ui/accessibility/ax_node_data.cc
+++ b/ui/accessibility/ax_node_data.cc
@@ -92,6 +92,7 @@ typename std::vector<std::pair<FirstType, SecondType>>::const_iterator
bool IsNodeIdIntAttribute(AXIntAttribute attr) {
switch (attr) {
case AX_ATTR_ACTIVEDESCENDANT_ID:
+ case AX_ATTR_DETAILS_ID:
case AX_ATTR_ERRORMESSAGE_ID:
case AX_ATTR_IN_PAGE_LINK_TARGET_ID:
case AX_ATTR_MEMBER_OF_ID:
@@ -157,7 +158,6 @@ bool IsNodeIdIntListAttribute(AXIntListAttribute attr) {
case AX_ATTR_CELL_IDS:
case AX_ATTR_CONTROLS_IDS:
case AX_ATTR_DESCRIBEDBY_IDS:
- case AX_ATTR_DETAILS_IDS:
case AX_ATTR_FLOWTO_IDS:
case AX_ATTR_INDIRECT_CHILD_IDS:
case AX_ATTR_LABELLEDBY_IDS:
@@ -624,6 +624,9 @@ std::string AXNodeData::ToString() const {
case AX_ATTR_ACTIVEDESCENDANT_ID:
result += " activedescendant=" + value;
break;
+ case AX_ATTR_DETAILS_ID:
+ result += " details=" + value;
+ break;
case AX_ATTR_ERRORMESSAGE_ID:
result += " errormessage=" + value;
break;
@@ -892,9 +895,6 @@ std::string AXNodeData::ToString() const {
case AX_ATTR_DESCRIBEDBY_IDS:
result += " describedby_ids=" + IntVectorToString(values);
break;
- case AX_ATTR_DETAILS_IDS:
- result += " details_ids=" + IntVectorToString(values);
- break;
case AX_ATTR_FLOWTO_IDS:
result += " flowto_ids=" + IntVectorToString(values);
break;
« no previous file with comments | « ui/accessibility/ax_enums.idl ('k') | ui/accessibility/ax_tree_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698