third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2946663003: content::RTCRtpSenders/Receivers using track adapter references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2946663003: content::RTCRtpSenders/Receivers using track adapter references. (Closed)

Patch Set: scoped_refptr and std::move Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/rtc_rtp_sender.cc ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index 4bc2b0f068069b4738eb3f00fcfd9f1cd64c2163..89fa869993328680e4b479c9fb1d4620091bac60 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -239,12 +239,6 @@ class MODULES_EXPORT RTCPeerConnection final

void ScheduleDispatchEvent(Event*, std::unique_ptr<BoolFunction>);

void DispatchScheduledEvent();

MediaStreamTrack* GetTrack(const WebMediaStreamTrack& web_track) const;

- // Senders and receivers returned by the handler are in use by the peer

- // connection, a sender or receiver that is no longer in use is permanently

- // inactive and does not need to be referenced anymore. These methods removes

- // such senders/receivers from |rtp_senders_|/|rtp_receivers_|.

- void RemoveInactiveSenders();

- void RemoveInactiveReceivers();

void ChangeSignalingState(WebRTCPeerConnectionHandlerClient::SignalingState);

void ChangeIceGatheringState(

@@ -273,8 +267,8 @@ class MODULES_EXPORT RTCPeerConnection final

// |rtp_receivers_|.

HeapHashMap<WeakMember<MediaStreamComponent>, WeakMember<MediaStreamTrack>>

tracks_;

- HeapHashMap<uintptr_t, Member<RTCRtpSender>> rtp_senders_;

- HeapHashMap<uintptr_t, Member<RTCRtpReceiver>> rtp_receivers_;

+ HeapHashMap<uintptr_t, WeakMember<RTCRtpSender>> rtp_senders_;

+ HeapHashMap<uintptr_t, WeakMember<RTCRtpReceiver>> rtp_receivers_;

std::unique_ptr<WebRTCPeerConnectionHandler> peer_handler_;