Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2946663003: content::RTCRtpSenders/Receivers using track adapter references. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
index 765b7e478b7d899c8bab5b3981751157a56755bf..2ef95610926c9f8293a2354e796e301900ab3d91 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
@@ -231,12 +231,6 @@ class RTCPeerConnection final : public EventTargetWithInlineData,
void DispatchScheduledEvent();
MediaStreamTrack* GetLocalTrackById(const String& track_id) const;
MediaStreamTrack* GetRemoteTrackById(const String& track_id) const;
- // Senders and receivers returned by the handler are in use by the peer
- // connection, a sender or receiver that is no longer in use is permanently
- // inactive and does not need to be referenced anymore. These methods removes
- // such senders/receivers from |rtp_senders_|/|rtp_receivers_|.
- void RemoveInactiveSenders();
- void RemoveInactiveReceivers();
void ChangeSignalingState(WebRTCPeerConnectionHandlerClient::SignalingState);
void ChangeIceGatheringState(
@@ -263,8 +257,8 @@ class RTCPeerConnection final : public EventTargetWithInlineData,
// relevant events. https://crbug.com/705901
MediaStreamVector local_streams_;
MediaStreamVector remote_streams_;
- HeapHashMap<uintptr_t, Member<RTCRtpSender>> rtp_senders_;
- HeapHashMap<uintptr_t, Member<RTCRtpReceiver>> rtp_receivers_;
+ HeapHashMap<uintptr_t, WeakMember<RTCRtpSender>> rtp_senders_;
+ HeapHashMap<uintptr_t, WeakMember<RTCRtpReceiver>> rtp_receivers_;
std::unique_ptr<WebRTCPeerConnectionHandler> peer_handler_;

Powered by Google App Engine
This is Rietveld 408576698