Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: content/renderer/media/webrtc/rtc_rtp_receiver.cc

Issue 2946663003: content::RTCRtpSenders/Receivers using track adapter references. (Closed)
Patch Set: scoped_refptr and std::move Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/webrtc/rtc_rtp_receiver.h" 5 #include "content/renderer/media/webrtc/rtc_rtp_receiver.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "content/renderer/media/webrtc/rtc_rtp_contributing_source.h" 9 #include "content/renderer/media/webrtc/rtc_rtp_contributing_source.h"
10 #include "third_party/webrtc/base/scoped_ref_ptr.h" 10 #include "third_party/webrtc/base/scoped_ref_ptr.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 namespace {
15
16 inline bool operator==(const blink::WebMediaStreamTrack& web_track,
17 const webrtc::MediaStreamTrackInterface& webrtc_track) {
18 return !web_track.IsNull() && web_track.Id() == webrtc_track.id().c_str();
19 }
20
21 } // namespace
22
23 uintptr_t RTCRtpReceiver::getId( 14 uintptr_t RTCRtpReceiver::getId(
24 const webrtc::RtpReceiverInterface* webrtc_rtp_receiver) { 15 const webrtc::RtpReceiverInterface* webrtc_rtp_receiver) {
25 return reinterpret_cast<uintptr_t>(webrtc_rtp_receiver); 16 return reinterpret_cast<uintptr_t>(webrtc_rtp_receiver);
26 } 17 }
27 18
28 RTCRtpReceiver::RTCRtpReceiver( 19 RTCRtpReceiver::RTCRtpReceiver(
29 webrtc::RtpReceiverInterface* webrtc_rtp_receiver, 20 scoped_refptr<webrtc::RtpReceiverInterface> webrtc_rtp_receiver,
30 const blink::WebMediaStreamTrack& web_track) 21 std::unique_ptr<WebRtcMediaStreamTrackAdapterMap::AdapterRef> track_adapter)
31 : webrtc_rtp_receiver_(webrtc_rtp_receiver), web_track_(web_track) { 22 : webrtc_rtp_receiver_(std::move(webrtc_rtp_receiver)),
23 track_adapter_(std::move(track_adapter)) {
32 DCHECK(webrtc_rtp_receiver_); 24 DCHECK(webrtc_rtp_receiver_);
33 DCHECK(!web_track_.IsNull()); 25 DCHECK(track_adapter_);
34 DCHECK(web_track_ == webrtc_track()); 26 DCHECK_EQ(track_adapter_->webrtc_track(), webrtc_rtp_receiver_->track());
35 } 27 }
36 28
37 RTCRtpReceiver::~RTCRtpReceiver() {} 29 RTCRtpReceiver::~RTCRtpReceiver() {}
38 30
39 uintptr_t RTCRtpReceiver::Id() const { 31 uintptr_t RTCRtpReceiver::Id() const {
40 return getId(webrtc_rtp_receiver_.get()); 32 return getId(webrtc_rtp_receiver_.get());
41 } 33 }
42 34
43 const blink::WebMediaStreamTrack& RTCRtpReceiver::Track() const { 35 const blink::WebMediaStreamTrack& RTCRtpReceiver::Track() const {
44 DCHECK(web_track_ == webrtc_track()); 36 DCHECK(track_adapter_->webrtc_track() == webrtc_rtp_receiver_->track());
45 return web_track_; 37 return track_adapter_->web_track();
46 } 38 }
47 39
48 blink::WebVector<std::unique_ptr<blink::WebRTCRtpContributingSource>> 40 blink::WebVector<std::unique_ptr<blink::WebRTCRtpContributingSource>>
49 RTCRtpReceiver::GetSources() { 41 RTCRtpReceiver::GetSources() {
50 auto webrtc_sources = webrtc_rtp_receiver_->GetSources(); 42 auto webrtc_sources = webrtc_rtp_receiver_->GetSources();
51 blink::WebVector<std::unique_ptr<blink::WebRTCRtpContributingSource>> sources( 43 blink::WebVector<std::unique_ptr<blink::WebRTCRtpContributingSource>> sources(
52 webrtc_sources.size()); 44 webrtc_sources.size());
53 for (size_t i = 0; i < webrtc_sources.size(); ++i) { 45 for (size_t i = 0; i < webrtc_sources.size(); ++i) {
54 sources[i] = base::MakeUnique<RTCRtpContributingSource>(webrtc_sources[i]); 46 sources[i] = base::MakeUnique<RTCRtpContributingSource>(webrtc_sources[i]);
55 } 47 }
56 return sources; 48 return sources;
57 } 49 }
58 50
59 const webrtc::MediaStreamTrackInterface& RTCRtpReceiver::webrtc_track() const { 51 const webrtc::MediaStreamTrackInterface& RTCRtpReceiver::webrtc_track() const {
60 const webrtc::MediaStreamTrackInterface* webrtc_track = 52 DCHECK(track_adapter_->webrtc_track() == webrtc_rtp_receiver_->track());
61 webrtc_rtp_receiver_->track(); 53 DCHECK(track_adapter_->webrtc_track());
62 DCHECK(webrtc_track); 54 return *track_adapter_->webrtc_track();
63 DCHECK(web_track_ == *webrtc_track);
64 return *webrtc_track;
65 } 55 }
66 56
67 } // namespace content 57 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698