content::RTCRtpSenders/Receivers using track adapter references.

content/renderer/media/webrtc/rtc_rtp_sender.cc

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webrtc/rtc_rtp_sender.h"
 
 #include "base/logging.h"
 #include "third_party/webrtc/base/scoped_ref_ptr.h"
 
 namespace content {
 
 namespace {
 
 inline bool operator==(
-    const std::unique_ptr<blink::WebMediaStreamTrack>& web_track,
+    const std::unique_ptr<WebRtcMediaStreamTrackAdapterMap::AdapterRef>&
+        track_adapter,
     const webrtc::MediaStreamTrackInterface* webrtc_track) {
-  if (!web_track)
+  if (!track_adapter)
     return !webrtc_track;
-  return webrtc_track && web_track->Id() == webrtc_track->id().c_str();
+  return track_adapter->webrtc_track() == webrtc_track;
 }
 
 }  // namespace
 
 uintptr_t RTCRtpSender::getId(
     const webrtc::RtpSenderInterface* webrtc_rtp_sender) {
   return reinterpret_cast<uintptr_t>(webrtc_rtp_sender);
 }
 
 RTCRtpSender::RTCRtpSender(
     webrtc::RtpSenderInterface* webrtc_rtp_sender,
-    std::unique_ptr<blink::WebMediaStreamTrack> web_track)
-    : webrtc_rtp_sender_(webrtc_rtp_sender), web_track_(std::move(web_track)) {
+    std::unique_ptr<WebRtcMediaStreamTrackAdapterMap::AdapterRef> track_adapter)
+    : webrtc_rtp_sender_(webrtc_rtp_sender),
+      track_adapter_(std::move(track_adapter)) {
   DCHECK(webrtc_rtp_sender_);
-  DCHECK(web_track_ == webrtc_track());
+  DCHECK(track_adapter_ == webrtc_rtp_sender_->track());

[Guido Urdaneta, 2017/06/19 16:10:51]

does DCHECK_EQ work here?

[hbos_chromium, 2017/06/19 16:45:39]

No, logging template stuff breaks, the code required to fix is not worth it for
a couple of DCHECKs.

[Guido Urdaneta, 2017/06/20 11:26:15]

Acknowledged.

 }
 
 RTCRtpSender::~RTCRtpSender() {}
 
 uintptr_t RTCRtpSender::Id() const {
   return getId(webrtc_rtp_sender_.get());
 }
 
 const blink::WebMediaStreamTrack* RTCRtpSender::Track() const {
-  DCHECK(web_track_ == webrtc_track());
-  return web_track_.get();
+  DCHECK(track_adapter_ == webrtc_rtp_sender_->track());

[Guido Urdaneta, 2017/06/19 16:10:51]

does DCHECK_EQ work here?

[hbos_chromium, 2017/06/19 16:45:39]

No.

[Guido Urdaneta, 2017/06/20 11:26:15]

Acknowledged.

+  return track_adapter_ ? &track_adapter_->web_track() : nullptr;
 }
 
 const webrtc::MediaStreamTrackInterface* RTCRtpSender::webrtc_track() const {
-  return webrtc_rtp_sender_->track();
+  DCHECK(track_adapter_ == webrtc_rtp_sender_->track());
+  return track_adapter_ ? track_adapter_->webrtc_track() : nullptr;
 }
 
 }  // namespace content