Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294663015: [Telemetry] Make Android work with a mac host. (Closed)

Created:
6 years, 7 months ago by tonyg
Modified:
6 years, 6 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Make Android work with a mac host. This uses the RNDIS forwarder on mac since the custom forwarder is pretty far from being able to compile on mac. The main work of the patch was just making the RNDIS forwarder work with ifconfig output instead of ip addr output. BUG=355646 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273125

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -56 lines) Patch
M tools/telemetry/telemetry/core/backends/adb_commands.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 11 chunks +61 lines, -54 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 7 months ago (2014-05-22 13:32:32 UTC) #1
tonyg
bump
6 years, 6 months ago (2014-05-28 00:57:09 UTC) #2
dtu
Bam! lgtm https://codereview.chromium.org/294663015/diff/1/tools/telemetry/telemetry/core/forwarders/android_forwarder.py File tools/telemetry/telemetry/core/forwarders/android_forwarder.py (right): https://codereview.chromium.org/294663015/diff/1/tools/telemetry/telemetry/core/forwarders/android_forwarder.py#newcode292 tools/telemetry/telemetry/core/forwarders/android_forwarder.py:292: return 0xFFFFFFFF & ~((1 << (32 - ...
6 years, 6 months ago (2014-05-28 01:15:29 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-05-28 01:21:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/294663015/1
6 years, 6 months ago (2014-05-28 01:22:16 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 03:00:14 UTC) #6
Message was sent while issue was closed. 
Change committed as 273125

Powered by Google App Engine
This is Rietveld 408576698