Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 294663013: Update install_build_deps.sh for Ubuntu Trusty. (Closed)

Created:
6 years, 7 months ago by Sam Clegg
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Update install_build_deps.sh for Ubuntu Trusty. Aside from accepting the new lsb distro name that only changes needed were to the arm cross compile packages list. This was reduced a minimal set. Also gcc-multilib in Trust conflicts with the arm cross compiler so we use gcc-4.8-multilib here instead. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272035

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M build/install-build-deps.sh View 1 2 4 chunks +14 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sam Clegg
6 years, 7 months ago (2014-05-21 23:40:09 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/294663013/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/294663013/diff/20001/build/install-build-deps.sh#newcode141 build/install-build-deps.sh:141: arm_list="libc6-dev-armhf-cross Probably want to update the CL description ...
6 years, 7 months ago (2014-05-21 23:46:41 UTC) #2
Lei Zhang
and add NOTRY=treu
6 years, 7 months ago (2014-05-21 23:46:53 UTC) #3
Sam Clegg
https://codereview.chromium.org/294663013/diff/20001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/294663013/diff/20001/build/install-build-deps.sh#newcode141 build/install-build-deps.sh:141: arm_list="libc6-dev-armhf-cross On 2014/05/21 23:46:41, Lei Zhang wrote: > Probably ...
6 years, 7 months ago (2014-05-22 00:14:08 UTC) #4
Lei Zhang
lgtm++
6 years, 7 months ago (2014-05-22 00:26:20 UTC) #5
Sam Clegg
The CQ bit was checked by sbc@chromium.org
6 years, 7 months ago (2014-05-22 00:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/294663013/40001
6 years, 7 months ago (2014-05-22 00:34:39 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 00:48:16 UTC) #8
Message was sent while issue was closed.
Change committed as 272035

Powered by Google App Engine
This is Rietveld 408576698