Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: Source/core/frame/DOMWindow.cpp

Issue 294663007: pageshow event does not follow spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Proposal 2 : Remove fixme from code Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/DOMWindow.cpp
diff --git a/Source/core/frame/DOMWindow.cpp b/Source/core/frame/DOMWindow.cpp
index 9d85771d908ce7868b7e3d666b68851fcef5a44d..555c733a5819c851d2ee24ca4935d5635c231e17 100644
--- a/Source/core/frame/DOMWindow.cpp
+++ b/Source/core/frame/DOMWindow.cpp
@@ -453,7 +453,8 @@ void DOMWindow::documentWasClosed()
void DOMWindow::enqueuePageshowEvent(PageshowEventPersistence persisted)
{
- // FIXME: https://bugs.webkit.org/show_bug.cgi?id=36334 Pageshow event needs to fire asynchronously.
tkent 2014/05/30 01:05:50 IMO we should not remove the FIXME. We should add
+ // As per spec pageshow must be triggered asyncronously.
Inactive 2014/05/29 21:19:39 asynchronously
+ // However to be compatible with other browsers blink fires pageshow syncronously.
dispatchEvent(PageTransitionEvent::create(EventTypeNames::pageshow, persisted), m_document.get());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698