Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 294663007: pageshow event does not follow spec (Closed)

Created:
6 years, 7 months ago by maheshkk
Modified:
6 years, 6 months ago
Reviewers:
tkent, Inactive
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not change pageshow event behavior though it does not follow spec As per spec step of history traversal algorithm (section 7.6.10): subsection 4.6 of http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history browser should queue a task to fire pageshow event. However chrome and other desktop browsers firefox30 and IE11) dispatches the event sync right after onload is triggered. Specification change requested for the same so just update the same in comments comments. BUG=378946 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175311

Patch Set 1 #

Patch Set 2 : Proposal 1 : Match spec #

Patch Set 3 : Proposal 2 : Remove fixme from code #

Total comments: 2

Patch Set 4 : Update comment #

Patch Set 5 : fix spell mistake #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/frame/DOMWindow.cpp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
maheshkk
PTAL
6 years, 6 months ago (2014-05-29 21:12:38 UTC) #1
Inactive
Please add an API OWNER as reviewer. https://codereview.chromium.org/294663007/diff/40001/Source/core/frame/DOMWindow.cpp File Source/core/frame/DOMWindow.cpp (right): https://codereview.chromium.org/294663007/diff/40001/Source/core/frame/DOMWindow.cpp#newcode456 Source/core/frame/DOMWindow.cpp:456: // As ...
6 years, 6 months ago (2014-05-29 21:19:39 UTC) #2
maheshkk
6 years, 6 months ago (2014-05-29 21:20:28 UTC) #3
maheshkk
PTAL More details and screenshot at https://code.google.com/p/chromium/issues/detail?id=378931
6 years, 6 months ago (2014-05-29 21:27:20 UTC) #4
tkent
https://codereview.chromium.org/294663007/diff/40001/Source/core/frame/DOMWindow.cpp File Source/core/frame/DOMWindow.cpp (left): https://codereview.chromium.org/294663007/diff/40001/Source/core/frame/DOMWindow.cpp#oldcode456 Source/core/frame/DOMWindow.cpp:456: // FIXME: https://bugs.webkit.org/show_bug.cgi?id=36334 Pageshow event needs to fire asynchronously. ...
6 years, 6 months ago (2014-05-30 01:05:49 UTC) #5
maheshkk
On 2014/05/30 01:05:49, tkent wrote: > https://codereview.chromium.org/294663007/diff/40001/Source/core/frame/DOMWindow.cpp > File Source/core/frame/DOMWindow.cpp (left): > > https://codereview.chromium.org/294663007/diff/40001/Source/core/frame/DOMWindow.cpp#oldcode456 > ...
6 years, 6 months ago (2014-05-30 21:36:13 UTC) #6
tkent
lgtm. Please update the CL description before landing.
6 years, 6 months ago (2014-06-01 23:20:09 UTC) #7
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 6 months ago (2014-06-02 16:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/294663007/80001
6 years, 6 months ago (2014-06-02 16:49:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-02 18:05:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 18:52:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9897)
6 years, 6 months ago (2014-06-02 18:52:39 UTC) #12
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 6 months ago (2014-06-02 18:55:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/294663007/80001
6 years, 6 months ago (2014-06-02 18:55:47 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:25:53 UTC) #15
Message was sent while issue was closed.
Change committed as 175311

Powered by Google App Engine
This is Rietveld 408576698