Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2946573003: Remove ReplacementRange (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
maxkim, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -70 lines) Patch
M pkg/analyzer_plugin/lib/src/utilities/completion/completion_target.dart View 2 chunks +48 lines, -0 lines 0 comments Download
D pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart View 1 chunk +0 lines, -68 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/completion/completion_contributor_util.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-17 16:27:21 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-17 22:31:44 UTC) #3
maxkim
lgtm
3 years, 6 months ago (2017-06-19 17:01:15 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-19 17:15:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eafc070479679151ed741d4709cb8a2abe454acf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698