Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: milo/common/config_test.go

Issue 2946443003: Milo: (Breaking proto change) Update console definition (Closed)
Patch Set: ImportFix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/buildbot/console_test.go ('k') | milo/frontend/console/console.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/common/config_test.go
diff --git a/milo/common/config_test.go b/milo/common/config_test.go
index 4762360317cfec011e6ec042b91cf998afb77ce8..b1907704de4001e32e53ea84c87f5fe7f138f1b2 100644
--- a/milo/common/config_test.go
+++ b/milo/common/config_test.go
@@ -59,8 +59,6 @@ func TestConfig(t *testing.T) {
p, err := GetProject(c, "foo")
So(err, ShouldBeNil)
So(p.ID, ShouldEqual, "foo")
- So(p.Readers, ShouldResemble, []string{"public", "foo@bar.com"})
- So(p.Writers, ShouldResemble, []string(nil))
})
Convey("Check Console config updated", func() {
@@ -85,21 +83,17 @@ func TestConfig(t *testing.T) {
var fooCfg = `
ID: "foo"
-Readers: "public"
-Readers: "foo@bar.com"
Consoles: {
Name: "default"
RepoURL: "https://chromium.googlesource.com/foo/bar"
Branch: "master"
Builders: {
- Module: "buildbucket"
- Name: "luci.foo.something"
+ Name: "buildbucket/luci.foo.something/bar"
Category: "main|something"
ShortName: "s"
}
Builders: {
- Module: "buildbucket"
- Name: "luci.foo.other"
+ Name: "buildbucket/luci.foo.other/baz"
Category: "main|other"
ShortName: "o"
}
« no previous file with comments | « milo/buildsource/buildbot/console_test.go ('k') | milo/frontend/console/console.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698