Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: milo/appengine/common/config_test.go

Issue 2946443003: Milo: (Breaking proto change) Update console definition (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/common/config_test.go
diff --git a/milo/appengine/common/config_test.go b/milo/appengine/common/config_test.go
index 6d20bd173d9567220a6545400d96614776e462f8..9d2a352dbe063d05b59042bc6852ca28109fed62 100644
--- a/milo/appengine/common/config_test.go
+++ b/milo/appengine/common/config_test.go
@@ -58,8 +58,6 @@ func TestConfig(t *testing.T) {
p, err := GetProject(c, "foo")
So(err, ShouldBeNil)
So(p.ID, ShouldEqual, "foo")
- So(p.Readers, ShouldResemble, []string{"public", "foo@bar.com"})
- So(p.Writers, ShouldResemble, []string(nil))
})
Convey("Check Console config updated", func() {
@@ -84,21 +82,17 @@ func TestConfig(t *testing.T) {
var fooCfg = `
ID: "foo"
-Readers: "public"
-Readers: "foo@bar.com"
Consoles: {
Name: "default"
RepoURL: "https://chromium.googlesource.com/foo/bar"
Branch: "master"
Builders: {
- Module: "buildbucket"
- Name: "luci.foo.something"
+ Name: "buildbucket/luci.foo.something/bar"
Category: "main|something"
ShortName: "s"
}
Builders: {
- Module: "buildbucket"
- Name: "luci.foo.other"
+ Name: "buildbucket/luci.foo.other/baz"
Category: "main|other"
ShortName: "o"
}

Powered by Google App Engine
This is Rietveld 408576698