Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Issue 2946393002: MD Settings: Amend SiteSettingsHandlerTest.Origins to test "Site Details" code. (Closed)
Patch Set: Remove camels. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A helper object used from the "Site Settings" section to 6 * @fileoverview A helper object used from the "Site Settings" section to
7 * interact with the content settings prefs. 7 * interact with the content settings prefs.
8 */ 8 */
9 9
10 /** 10 /**
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 * may be different to the results retrieved by getExceptionList(), since it 143 * may be different to the results retrieved by getExceptionList(), since it
144 * combines different sources of data to get a permission's value. 144 * combines different sources of data to get a permission's value.
145 * @param {string} origin The origin to look up permissions for. 145 * @param {string} origin The origin to look up permissions for.
146 * @param {!Array<string>} contentTypes A list of categories to retrieve 146 * @param {!Array<string>} contentTypes A list of categories to retrieve
147 * the ContentSetting for. 147 * the ContentSetting for.
148 * @return {!Promise<!NodeList<!RawSiteException>>} 148 * @return {!Promise<!NodeList<!RawSiteException>>}
149 */ 149 */
150 getOriginPermissions(origin, contentTypes) {} 150 getOriginPermissions(origin, contentTypes) {}
151 151
152 /** 152 /**
153 * Gets a list of category permissions for a given origin. Note that this
154 * may be different to the results retrieved by getExceptionList(), since it
155 * combines different sources of data to get a permission's value.
156 * @param {string} origin The origin to look up permissions for.
157 * @param {!Array<string>} contentTypes A list of categories to retrieve
158 * the ContentSetting for.
159 * @return {!Promise<!NodeList<!RawSiteException>>}
160 */
161 getOriginPermissions(origin, contentTypes) {}
dschuyler 2017/07/05 18:30:18 It looks like this is being added a second time (m
Patti Lor 2017/07/06 04:23:40 Oops, thanks for picking this up! Fixed.
162
163 /**
153 * Sets the category permission for a given origin (expressed as primary 164 * Sets the category permission for a given origin (expressed as primary
154 * and secondary patterns). 165 * and secondary patterns).
155 * @param {string} primaryPattern The origin to change (primary pattern). 166 * @param {string} primaryPattern The origin to change (primary pattern).
156 * @param {string} secondaryPattern The embedding origin to change 167 * @param {string} secondaryPattern The embedding origin to change
157 * (secondary pattern). 168 * (secondary pattern).
158 * @param {string} contentType The name of the category to change. 169 * @param {string} contentType The name of the category to change.
159 * @param {string} value The value to change the permission to. 170 * @param {string} value The value to change the permission to.
160 * @param {boolean} incognito Whether this rule applies only to the current 171 * @param {boolean} incognito Whether this rule applies only to the current
161 * incognito session. 172 * incognito session.
162 */ 173 */
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 434
424 // The singleton instance_ is replaced with a test version of this wrapper 435 // The singleton instance_ is replaced with a test version of this wrapper
425 // during testing. 436 // during testing.
426 cr.addSingletonGetter(SiteSettingsPrefsBrowserProxyImpl); 437 cr.addSingletonGetter(SiteSettingsPrefsBrowserProxyImpl);
427 438
428 return { 439 return {
429 SiteSettingsPrefsBrowserProxy: SiteSettingsPrefsBrowserProxy, 440 SiteSettingsPrefsBrowserProxy: SiteSettingsPrefsBrowserProxy,
430 SiteSettingsPrefsBrowserProxyImpl: SiteSettingsPrefsBrowserProxyImpl, 441 SiteSettingsPrefsBrowserProxyImpl: SiteSettingsPrefsBrowserProxyImpl,
431 }; 442 };
432 }); 443 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698