Added 1 liner to fix shelf background hiding on side shelf alignment.

ash/app_list/app_list_presenter_delegate_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "ash/ash_switches.h"
 #include "ash/public/cpp/config.h"
+#include "ash/public/cpp/shelf_types.h"
 #include "ash/public/cpp/shell_window_ids.h"
+#include "ash/shelf/shelf.h"
+#include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/test_app_list_view_presenter_impl.h"
 #include "ash/wm/window_util.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/test/scoped_feature_list.h"
 #include "ui/app_list/app_list_features.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/views/app_list_main_view.h"
@@ skipping 203 matching lines @@
 
   app_list_presenter_impl()->Show(GetPrimaryDisplayId());
   EXPECT_TRUE(app_list_presenter_impl()->GetTargetVisibility());
 
   // Clicking outside the bounds closes the app list.
   generator.MoveMouseTo(tap_point);
   generator.ClickLeftButton();
   EXPECT_FALSE(app_list_presenter_impl()->GetTargetVisibility());
 }
 
+// Tests that the shelf background displays/hides with bottom/side shelf
+// alignment.
+TEST_F(AppListPresenterDelegateTest,
+       ShelfBackgroundRespondsToAppListBeingShown) {
+  EnableFullscreenAppList();
+  Shelf* shelf =

[James Cook, 2017/06/21 23:57:32]

nit: You can just do GetPrimaryShelf().  It's a method on AshTestBase.

[newcomer, 2017/06/22 00:16:09]

Wow Awesome. Thanks!

+      Shelf::ForWindow(Shell::GetRootWindowForDisplayId(GetPrimaryDisplayId()));
+  shelf->SetAlignment(SHELF_ALIGNMENT_BOTTOM);
+
+  // Show the app list, the shelf background should be hidden.

[James Cook, 2017/06/21 23:57:32]

super-nit: "hidden" sounds like shelf autohide. I would say "transparent".

[newcomer, 2017/06/22 00:16:08]

Done.

+  app_list_presenter_impl()->Show(GetPrimaryDisplayId());
+  ShelfLayoutManager* shelf_layout_manager = shelf->shelf_layout_manager();
+  EXPECT_EQ(shelf_layout_manager->GetShelfBackgroundType(),
+            SHELF_BACKGROUND_DEFAULT);
+  app_list_presenter_impl()->Dismiss();
+  // Set the alignment to the side and show the app list. The background should

[vadimt, 2017/06/21 23:45:32]

nit: empty line before

[newcomer, 2017/06/22 00:16:08]

Done.

+  // show.
+  shelf->SetAlignment(ShelfAlignment::SHELF_ALIGNMENT_LEFT);
+  app_list_presenter_impl()->Show(GetPrimaryDisplayId());
+  EXPECT_EQ(shelf_layout_manager->GetShelfBackgroundType(),
+            SHELF_BACKGROUND_OVERLAP);
+}
 }  // namespace ash

[James Cook, 2017/06/21 23:57:32]

nit: blank line above

[newcomer, 2017/06/22 00:16:08]

Done.