Restore partial analysis of analysis options files

Restore partial analysis of analysis options files

R=devoncarew@google.com

Committed: https://github.com/dart-lang/sdk/commit/e28064f4050267c77a55d257010baf8198e7a2bd

[Brian Wilkerson, 2017-06-21 20:50:34]

brianwilkerson@google.com changed reviewers:
+ devoncarew@google.com, scheglov@google.com

[Brian Wilkerson, 2017-06-21 20:50:34]

This causes analysis server to analyze analysis options files when the context
root containing them is first analyzed and when the file changes on disk.

It does not add this functionality to the command-line analyzer, nor does it
handle analysis while the user is typing.

It also fixes some errors and lints discovered after enabling the analysis.

[devoncarew, 2017-06-22 14:49:22]

lgtm

Great to see this re-enabled :) I expect we'll see a lot of fixes to people's
analysis_options files over the next few weeks.

https://codereview.chromium.org/2946313003/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_options.yaml (right):

https://codereview.chromium.org/2946313003/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_options.yaml:7: -
unnecessary_brace_in_string_interps
awesome! nice to see it working

[Brian Wilkerson, 2017-06-22 15:00:55]

Description was changed from

==========
Restore partial analysis of analysis options files
==========

to

==========
Restore partial analysis of analysis options files

R=devoncarew@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e28064f4050267c77a55d257010baf8198e7a2bd
==========

[Brian Wilkerson, 2017-06-22 15:00:57]

Committed patchset #1 (id:1) manually as
e28064f4050267c77a55d257010baf8198e7a2bd (presubmit successful).

[scheglov, 2017-06-26 15:58:36]

LGTM